Re: Fix for "Implement VFS read clustering for MSDOSFS"

2017-05-29 Thread Martin Pieuchot
On 29/05/17(Mon) 14:30, Stefan Fritsch wrote: > On Mon, 29 May 2017, Martin Pieuchot wrote: > > > A complete diff would be easier to review. > > ok, here it comes. > > The original commit message was this: > > Implement VFS read clustering for MSDOSFS. > > The logic used in msd

Re: Fix for "Implement VFS read clustering for MSDOSFS"

2017-05-29 Thread Stefan Fritsch
On Mon, 29 May 2017, Martin Pieuchot wrote: > A complete diff would be easier to review. ok, here it comes. The original commit message was this: Implement VFS read clustering for MSDOSFS. The logic used in msdosfs_bmap() to loop calling pcbmap() comes from FreeBSD and is

Re: Fix for "Implement VFS read clustering for MSDOSFS"

2017-05-29 Thread Martin Pieuchot
On 29/05/17(Mon) 14:15, Stefan Fritsch wrote: > Last year, mpi@ implemented VFS read clustering for MSDOSFS in > > sys/msdosfs/denode.h 1.28 > sys/msdosfs/msdosfs_vnops.c 1.105 > > This caused regressions when doing seeks past the end of the file and had > to be reverted. > > I have now written

Fix for "Implement VFS read clustering for MSDOSFS"

2017-05-29 Thread Stefan Fritsch
Last year, mpi@ implemented VFS read clustering for MSDOSFS in sys/msdosfs/denode.h 1.28 sys/msdosfs/msdosfs_vnops.c 1.105 This caused regressions when doing seeks past the end of the file and had to be reverted. I have now written a test that catches the bug (committed in regress/sys/fileops)