Re: Fix the mtime for file creation on ext2+

2014-05-06 Thread Ted Unangst
On Tue, May 06, 2014 at 08:36, Philip Guenther wrote: > > As the person who broke this (sorry!), I think the diff should go a couple > steps further and restore the IN_ACCESS handling too and mirror > ufs_itimes() by bumping i_modrev on ctime change. As my commit message said, "it may even work

Re: Fix the mtime for file creation on ext2+

2014-05-06 Thread Kenneth Westerback
On 6 May 2014 15:12, Vadim Zhukov wrote: > 06.05.2014 19:36 пользователь "Philip Guenther" > написал: >> >> On Tue, 6 May 2014, Vadim Zhukov wrote: >> > This fixes a bug with mtime not updated after file creation on ext2+ >> > file systems. Try it yourself: >> > >> > # mount -t ext2fs /dev/sd0o /

Re: Fix the mtime for file creation on ext2+

2014-05-06 Thread Vadim Zhukov
06.05.2014 19:36 пользователь "Philip Guenther" написал: > > On Tue, 6 May 2014, Vadim Zhukov wrote: > > This fixes a bug with mtime not updated after file creation on ext2+ > > file systems. Try it yourself: > > > > # mount -t ext2fs /dev/sd0o /mnt > > # cp /tmp/qq /mnt > > # ls -l /mnt/qq > > -r

Re: Fix the mtime for file creation on ext2+

2014-05-06 Thread Philip Guenther
On Tue, 6 May 2014, Vadim Zhukov wrote: > This fixes a bug with mtime not updated after file creation on ext2+ > file systems. Try it yourself: > > # mount -t ext2fs /dev/sd0o /mnt > # cp /tmp/qq /mnt > # ls -l /mnt/qq > -rw-r--r-- 1 root wheel 10 Jan 1 1970 qq > # touch /mnt/qq > -rw-r--r

Re: Fix the mtime for file creation on ext2+

2014-05-06 Thread Kenneth Westerback
On 6 May 2014 06:42, Vadim Zhukov wrote: > Hello all. > > This fixes a bug with mtime not updated after file creation on ext2+ > file systems. Try it yourself: > > # mount -t ext2fs /dev/sd0o /mnt > # cp /tmp/qq /mnt > # ls -l /mnt/qq > -rw-r--r-- 1 root wheel 10 Jan 1 1970 qq > # touch /m

Fix the mtime for file creation on ext2+

2014-05-06 Thread Vadim Zhukov
Hello all. This fixes a bug with mtime not updated after file creation on ext2+ file systems. Try it yourself: # mount -t ext2fs /dev/sd0o /mnt # cp /tmp/qq /mnt # ls -l /mnt/qq -rw-r--r-- 1 root wheel 10 Jan 1 1970 qq # touch /mnt/qq -rw-r--r-- 1 root wheel 10 May 6 14:36 qq This