Re: HAMMER2 filesystem for OpenBSD

2023-10-20 Thread Stuart Henderson
On 2023/10/20 11:51, Chris Narkiewicz wrote:
> On Thu, 2023-10-19 at 15:03 +0200, Denis Fondras wrote:
> > 
> > https://marc.info/?l=openbsd-misc=169272174500676=2
> > 
> > 
> 
> Thank you, I missed that one.
> 
> So the key piece of information from that thread is that
> Kusumi's implementation of HAMMER2 for OpenBSD is read-only.

It was read-only then. That changed in 1.1.5. But the netbsd_hammer2
and openbsd_hammer2 repos say

"This repository will be abandoned once Linux or FreeBSD is stabilized
with write support. NetBSD is not the main target."

and

"This repository will be abandoned once Linux or FreeBSD is stabilized
with write support. OpenBSD is not the main area of interest."



Re: HAMMER2 filesystem for OpenBSD

2023-10-20 Thread Chris Narkiewicz
On Thu, 2023-10-19 at 15:03 +0200, Denis Fondras wrote:
> 
> https://marc.info/?l=openbsd-misc=169272174500676=2
> 
> 

Thank you, I missed that one.

So the key piece of information from that thread is that
Kusumi's implementation of HAMMER2 for OpenBSD is read-only.

Cheers,
Chris



Re: HAMMER2 filesystem for OpenBSD

2023-10-19 Thread Denis Fondras
Le Tue, Oct 17, 2023 at 10:14:25PM +0100, Chris Narkiewicz a écrit :
> Hi,
> 
> Tomohiro Kusumi is currently working on HAMMER2 implementation
> for OpenBSD, FreeBSD and NetBSD.
> 
> The repository is here:
> https://github.com/kusumi/openbsd_hammer2
> 
> 
> He maintains repositories for NetBSD, FreeBSD and OpenBSD, which
> suggests that the implementation is portable. He also
> provides a patch for OpenBSD 7.3:
> 
> https://github.com/kusumi/openbsd_hammer2/blob/master/patch/openbsd73.patch
> 
> The patch looks very minimal to me, with no deeper changes to the
> kernel.
> 
> I haven't found any discussion about HAMMER2 in list archives, so I'd
> like to bring it to devs attention, kindly asking for your opinion.

https://marc.info/?l=openbsd-misc=169272174500676=2

> Does it look like it's worth bringing in? Does it require more work?
> 
> I'd appreciate any opinions from more knowledgable crowd.
> 
> Cheers,
> Chris
> 



Re: HAMMER2 filesystem for OpenBSD

2023-10-17 Thread Greg Steuck
Chris Narkiewicz  writes:

> On Tue, 2023-10-17 at 16:22 -0600, Theo de Raadt wrote:
>> What will come of this discussion of opinions?
>
> If it's doable and the code quality is acceptable, I see 2 outcomes:
> 1. I could start looking for sponsorship, as I feel like my level of
> expertise is too limited to chew it myself
> 2. perhaps with a right guidance I could try to bite it myself (not so
> sure about it, but keen on finding out).
>
> I'm trying to contact the author atm to discuss his position and his
> plans regarding the code so see if there is any alignment.
>
> Week ago, he added a disclaimer in the readme that he plans shift his
> focus when FreeBSD write support is stabilized. If there is a limited
> window of opportunity, I thought it's worth looking at it while there
> is active interest.
>
> TBH, I don't know what would it take. The patch looks minimal, but I
> suspect it's just tip of the iceberg and I lack the knowledge to
> estimate how big the underwater part is. Especially the cost of
> maintenance. Therefore, I decided to reach out to tech, kindly asking
> about devs opinion or technical expertise on that matter.

Pointing to a repository with a diff against an old tree is minimally
interesting. If you report that you tested it and detail the outcome,
the level of interest may rise to the point that somebody else might
try. You can substantially increase the chances by forward-porting the
change to -current and testing it.

Thanks
Greg



Re: HAMMER2 filesystem for OpenBSD

2023-10-17 Thread Chris Narkiewicz
On Tue, 2023-10-17 at 16:22 -0600, Theo de Raadt wrote:
> What will come of this discussion of opinions?

If it's doable and the code quality is acceptable, I see 2 outcomes:
1. I could start looking for sponsorship, as I feel like my level of
expertise is too limited to chew it myself
2. perhaps with a right guidance I could try to bite it myself (not so
sure about it, but keen on finding out).

I'm trying to contact the author atm to discuss his position and his
plans regarding the code so see if there is any alignment.

Week ago, he added a disclaimer in the readme that he plans shift his
focus when FreeBSD write support is stabilized. If there is a limited
window of opportunity, I thought it's worth looking at it while there
is active interest.

TBH, I don't know what would it take. The patch looks minimal, but I
suspect it's just tip of the iceberg and I lack the knowledge to
estimate how big the underwater part is. Especially the cost of
maintenance. Therefore, I decided to reach out to tech, kindly asking
about devs opinion or technical expertise on that matter.

If such effort is not aligned with OpenBSD plans, I'll stop here.

Cheers,
Chris



Re: HAMMER2 filesystem for OpenBSD

2023-10-17 Thread Theo de Raadt
What will come of this discussion of opinions?

Chris Narkiewicz  wrote:

> Hi,
> 
> Tomohiro Kusumi is currently working on HAMMER2 implementation
> for OpenBSD, FreeBSD and NetBSD.
> 
> The repository is here:
> https://github.com/kusumi/openbsd_hammer2
> 
> 
> He maintains repositories for NetBSD, FreeBSD and OpenBSD, which
> suggests that the implementation is portable. He also
> provides a patch for OpenBSD 7.3:
> 
> https://github.com/kusumi/openbsd_hammer2/blob/master/patch/openbsd73.patch
> 
> The patch looks very minimal to me, with no deeper changes to the
> kernel.
> 
> I haven't found any discussion about HAMMER2 in list archives, so I'd
> like to bring it to devs attention, kindly asking for your opinion.
> Does it look like it's worth bringing in? Does it require more work?
> 
> I'd appreciate any opinions from more knowledgable crowd.
> 
> Cheers,
> Chris
> 



HAMMER2 filesystem for OpenBSD

2023-10-17 Thread Chris Narkiewicz
Hi,

Tomohiro Kusumi is currently working on HAMMER2 implementation
for OpenBSD, FreeBSD and NetBSD.

The repository is here:
https://github.com/kusumi/openbsd_hammer2


He maintains repositories for NetBSD, FreeBSD and OpenBSD, which
suggests that the implementation is portable. He also
provides a patch for OpenBSD 7.3:

https://github.com/kusumi/openbsd_hammer2/blob/master/patch/openbsd73.patch

The patch looks very minimal to me, with no deeper changes to the
kernel.

I haven't found any discussion about HAMMER2 in list archives, so I'd
like to bring it to devs attention, kindly asking for your opinion.
Does it look like it's worth bringing in? Does it require more work?

I'd appreciate any opinions from more knowledgable crowd.

Cheers,
Chris