Re: IPsec tdb ddb print

2021-11-18 Thread Alexander Bluhm
On Thu, Nov 18, 2021 at 10:00:28AM +0100, Claudio Jeker wrote: > > > I think this needs to be ntohs(tdb->tdb_udpencap_port) since it is still > > > stored in network byte order. > > > > With ntohs, it's "udpencap_port: " > > I would also use %d as format string. This is just a simple port

Re: IPsec tdb ddb print

2021-11-18 Thread Claudio Jeker
On Thu, Nov 18, 2021 at 08:50:37AM +, Stuart Henderson wrote: > On 2021/11/18 09:15, Claudio Jeker wrote: > > On Thu, Nov 18, 2021 at 08:10:26AM +, Stuart Henderson wrote: > > > On 2021/11/15 17:23, Alexander Bluhm wrote: > > > > + DUMP(ids, "%p"); > > > > + DUMP

Re: IPsec tdb ddb print

2021-11-18 Thread Stuart Henderson
On 2021/11/18 09:15, Claudio Jeker wrote: > On Thu, Nov 18, 2021 at 08:10:26AM +, Stuart Henderson wrote: > > On 2021/11/15 17:23, Alexander Bluhm wrote: > > > + DUMP(ids, "%p"); > > > + DUMP(ids_swapped, "%d"); > > > + DUMP(mtu, "%d"); > > > + DUMP(mtutimeout, "

Re: IPsec tdb ddb print

2021-11-18 Thread Claudio Jeker
On Thu, Nov 18, 2021 at 08:10:26AM +, Stuart Henderson wrote: > On 2021/11/15 17:23, Alexander Bluhm wrote: > > + DUMP(ids, "%p"); > > + DUMP(ids_swapped, "%d"); > > + DUMP(mtu, "%d"); > > + DUMP(mtutimeout, "%lld"); > > + pr("%18s: %08x\n", "ud

Re: IPsec tdb ddb print

2021-11-18 Thread Stuart Henderson
On 2021/11/15 17:23, Alexander Bluhm wrote: > + DUMP(ids, "%p"); > + DUMP(ids_swapped, "%d"); > + DUMP(mtu, "%d"); > + DUMP(mtutimeout, "%lld"); > + pr("%18s: %08x\n", "udpencap_port", > + ntohl(tdb->tdb_udpencap_port)); n

Re: IPsec tdb ddb print

2021-11-16 Thread Vitaliy Makkoveev
On Mon, Nov 15, 2021 at 05:23:43PM +0100, Alexander Bluhm wrote: > Hi, > > To debug IPsec and tdb refcounting it may be useful to have "show > tdb" and "show all tdbs" in ddb. > > ok? > Indeed this is useful. ok mvs@ > bluhm > > Index: share/man/man4/ddb.4 > =

Re: IPsec tdb ddb print

2021-11-15 Thread Hrvoje Popovski
On 15.11.2021. 17:23, Alexander Bluhm wrote: > Hi, > > To debug IPsec and tdb refcounting it may be useful to have "show > tdb" and "show all tdbs" in ddb. Here's panic with this and mvs@ version of "IPsec tdb ref counting" diff r620-1# > tdb_free() killing ourself panic: kernel diagnos

IPsec tdb ddb print

2021-11-15 Thread Alexander Bluhm
Hi, To debug IPsec and tdb refcounting it may be useful to have "show tdb" and "show all tdbs" in ddb. ok? bluhm Index: share/man/man4/ddb.4 === RCS file: /data/mirror/openbsd/cvs/src/share/man/man4/ddb.4,v retrieving revision 1.99