> > Thanks.
>
> Looking again I saw no obvious issues.
\o/
> >> > + if (EC_GROUP_get_order(group, order, ctx) == 0) {
> >> > + /*
> >> > +* XXX EC_GROUP_get_order() will return 0 if successful
> >> > but
> >> > +* XXX order == 0. But then BN_m
2014-11-10 17:29 GMT+03:00 Miod Vallat :
>> > The following diff attempts to polish the GOST code in libcrypto and add
>> > many missing error checks (probably not exhaustive, but a good start).
>>
>> I knew that I'm not perfect, but I didn't know the depth of my
>> imperfectness...
>
> Well, most
> > The following diff attempts to polish the GOST code in libcrypto and add
> > many missing error checks (probably not exhaustive, but a good start).
>
> I knew that I'm not perfect, but I didn't know the depth of my
> imperfectness...
Well, most of these shortcomings are also present in the `
Hello,
2014-11-10 2:12 GMT+03:00 Miod Vallat :
> The following diff attempts to polish the GOST code in libcrypto and add
> many missing error checks (probably not exhaustive, but a good start).
I knew that I'm not perfect, but I didn't know the depth of my imperfectness...
I will review your ch
The following diff attempts to polish the GOST code in libcrypto and add
many missing error checks (probably not exhaustive, but a good start).
A few KNF changes are included because I'm a tad too lazy to manually
split the diff at this point...
Important changes are mostly:
- VKO_compute_key() i
