Re: MPLSv6 1/2: kernel diff

2019-01-28 Thread Claudio Jeker
On Mon, Jan 28, 2019 at 01:36:44PM +1000, David Gwynne wrote: > > > > On 27 Dec 2018, at 5:42 pm, Claudio Jeker wrote: > > > > On Wed, Dec 26, 2018 at 09:27:59PM +0100, Denis Fondras wrote: > >> Resend because of nasty typo :/ > >> > >> On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin

Re: MPLSv6 1/2: kernel diff

2019-01-28 Thread Martin Pieuchot
On 28/01/19(Mon) 13:36, David Gwynne wrote: > > > > On 27 Dec 2018, at 5:42 pm, Claudio Jeker wrote: > > > > On Wed, Dec 26, 2018 at 09:27:59PM +0100, Denis Fondras wrote: > >> Resend because of nasty typo :/ > >> > >> On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > >>> I'm

Re: MPLSv6 1/2: kernel diff

2019-01-27 Thread David Gwynne
> On 27 Dec 2018, at 5:42 pm, Claudio Jeker wrote: > > On Wed, Dec 26, 2018 at 09:27:59PM +0100, Denis Fondras wrote: >> Resend because of nasty typo :/ >> >> On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: >>> I'm not happy with adding the IFF_MULTICAST flag and

Re: MPLSv6 1/2: kernel diff

2018-12-27 Thread Denis Fondras
On Thu, Dec 27, 2018 at 03:23:07PM -0200, Martin Pieuchot wrote: > On 26/12/18(Wed) 17:13, Denis Fondras wrote: > > Interface needs IFF_MULTICAST when enabling IPv6 as per in6_ifattach(). > > When an address is configured, the interface joins multicast groups with > > in6_joingroup() (hence use

Re: MPLSv6 1/2: kernel diff

2018-12-27 Thread Martin Pieuchot
On 26/12/18(Wed) 17:13, Denis Fondras wrote: > On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > > I'm not happy with adding the IFF_MULTICAST flag and SIOC{ADD,DEL}MULTI > > ioctls. It seems to be a common pattern between in existing pseudo-driver, > > so this shouldn't block

Re: MPLSv6 1/2: kernel diff

2018-12-26 Thread Claudio Jeker
On Wed, Dec 26, 2018 at 09:27:59PM +0100, Denis Fondras wrote: > Resend because of nasty typo :/ > > On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > > I'm not happy with adding the IFF_MULTICAST flag and SIOC{ADD,DEL}MULTI > > ioctls. It seems to be a common pattern between in

Re: MPLSv6 1/2: kernel diff

2018-12-26 Thread Denis Fondras
Please ignore, this one is broken... On Wed, Dec 26, 2018 at 09:27:59PM +0100, Denis Fondras wrote: > Resend because of nasty typo :/ > > On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > > I'm not happy with adding the IFF_MULTICAST flag and SIOC{ADD,DEL}MULTI > > ioctls. It

Re: MPLSv6 1/2: kernel diff

2018-12-26 Thread Denis Fondras
Resend because of nasty typo :/ On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > I'm not happy with adding the IFF_MULTICAST flag and SIOC{ADD,DEL}MULTI > ioctls. It seems to be a common pattern between in existing pseudo-driver, > so this shouldn't block you. However I'd

Re: MPLSv6 1/2: kernel diff

2018-12-26 Thread Denis Fondras
On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > I'm not happy with adding the IFF_MULTICAST flag and SIOC{ADD,DEL}MULTI > ioctls. It seems to be a common pattern between in existing pseudo-driver, > so this shouldn't block you. However I'd greatly appreciate if you > could

Re: MPLSv6 1/2: kernel diff

2018-12-25 Thread Martin Pieuchot
On 25/12/18(Tue) 20:05, Denis Fondras wrote: > On Tue, Dec 25, 2018 at 04:50:17PM -0200, Martin Pieuchot wrote: > > On 25/12/18(Tue) 10:25, Denis Fondras wrote: > > > On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > > > > On 24/12/18(Mon) 17:31, Denis Fondras wrote: > > > > >

Re: MPLSv6 1/2: kernel diff

2018-12-25 Thread Denis Fondras
On Tue, Dec 25, 2018 at 04:50:17PM -0200, Martin Pieuchot wrote: > On 25/12/18(Tue) 10:25, Denis Fondras wrote: > > On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > > > On 24/12/18(Mon) 17:31, Denis Fondras wrote: > > > > Index: net/if_ethersubr.c > > > >

Re: MPLSv6 1/2: kernel diff

2018-12-25 Thread Martin Pieuchot
On 25/12/18(Tue) 10:25, Denis Fondras wrote: > On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > > On 24/12/18(Mon) 17:31, Denis Fondras wrote: > > > Index: net/if_ethersubr.c > > > === > > > RCS file:

Re: MPLSv6 1/2: kernel diff

2018-12-25 Thread Denis Fondras
On Mon, Dec 24, 2018 at 08:43:10PM -0200, Martin Pieuchot wrote: > On 24/12/18(Mon) 17:31, Denis Fondras wrote: > > Index: net/if_ethersubr.c > > === > > RCS file: /cvs/src/sys/net/if_ethersubr.c,v > > retrieving revision 1.256 > >

Re: MPLSv6 1/2: kernel diff

2018-12-24 Thread Martin Pieuchot
On 24/12/18(Mon) 17:31, Denis Fondras wrote: > Thank you for the comments Martin. Here is an improved diff. I think you should commit the icmp6_do_error() refactoring. It's ok mpi@ with some nits below. It would be great if you could think the IPv4 version as well to take a 'struct sockaddr'

Re: MPLSv6 1/2: kernel diff

2018-12-24 Thread Denis Fondras
Thank you for the comments Martin. Here is an improved diff. On Sun, Dec 23, 2018 at 02:22:45PM -0200, Martin Pieuchot wrote: > Comments below > > > Index: net/if_ethersubr.c > > === > > RCS file: /cvs/src/sys/net/if_ethersubr.c,v

Re: MPLSv6 1/2: kernel diff

2018-12-23 Thread Martin Pieuchot
On 18/12/18(Tue) 12:13, Denis Fondras wrote: > Here is a serie of diffs to enable MPLSv6, MPLS transport over IPv6. Nice! > First diff : allow mpe(4) to handle IPv6 trafic. Comments below > Index: net/if_ethersubr.c > === > RCS

MPLSv6 1/2: kernel diff

2018-12-18 Thread Denis Fondras
Here is a serie of diffs to enable MPLSv6, MPLS transport over IPv6. First diff : allow mpe(4) to handle IPv6 trafic. Index: net/if_ethersubr.c === RCS file: /cvs/src/sys/net/if_ethersubr.c,v retrieving revision 1.255 diff -u -p