Re: Make em(4) more mpsafe again

2016-01-14 Thread Alexey Suslikov
Juuso Lapinlampi partyvan.eu> writes: > > - * These parameters control when the driver calls the routine to reclaim > > - * transmit descriptors. > > + * Thise parameter controls the minimum number of available transmit > > + * descriptors needed before we attempt transmission of a packet. > >

Re: Make em(4) more mpsafe again

2016-01-04 Thread Juuso Lapinlampi
> /* > - * These parameters control when the driver calls the routine to reclaim > - * transmit descriptors. > + * Thise parameter controls the minimum number of available transmit > + * descriptors needed before we attempt transmission of a packet. > */ There seems to be a typo in there. s/Thi

Re: Make em(4) more mpsafe again

2016-01-02 Thread Gregor Best
Hi David and tech@, I just tried the patch on a December 28 snapshot and got a watchdog timeout while running iperf. Just the snapshot without the patch survives iperf without a timeout. The device in question is this one: em0 at pci1 dev 0 function 0 "Intel 82583V" rev 0x00: msi, addres

Re: Make em(4) more mpsafe again

2016-01-02 Thread Hrvoje Popovski
On 31.12.2015. 15:08, David Gwynne wrote: > On Sat, Dec 05, 2015 at 03:41:24PM +0100, Claudio Jeker wrote: >> So Mark and I spent some time to figure out what the issue was with ix(4) >> based on that info I resurected the em(4) mpsafe diff that got backed out >> and I applied the same fix. It is s

Re: Make em(4) more mpsafe again

2015-12-31 Thread Gregor Best
On Fri, Jan 01, 2016 at 12:08:53AM +1000, David Gwynne wrote: > [...] > tests? ok? > [...] I'll test it tonight in my hackerspace. There's never a better time for testing network patches than new years eve, since people will be drunk enough to ignore occasional glitches when I restart the router :

Re: Make em(4) more mpsafe again

2015-12-31 Thread David Gwynne
On Sat, Dec 05, 2015 at 03:41:24PM +0100, Claudio Jeker wrote: > So Mark and I spent some time to figure out what the issue was with ix(4) > based on that info I resurected the em(4) mpsafe diff that got backed out > and I applied the same fix. It is somewhat unclear if this fixes the > watchdog ti

Re: Make em(4) more mpsafe again

2015-12-23 Thread Hrvoje Popovski
On 11.12.2015. 10:47, Martin Pieuchot wrote: > On 05/12/15(Sat) 15:41, Claudio Jeker wrote: >> So Mark and I spent some time to figure out what the issue was with ix(4) >> based on that info I resurected the em(4) mpsafe diff that got backed out >> and I applied the same fix. It is somewhat unclear

Re: Make em(4) more mpsafe again

2015-12-11 Thread Martin Pieuchot
On 05/12/15(Sat) 15:41, Claudio Jeker wrote: > So Mark and I spent some time to figure out what the issue was with ix(4) > based on that info I resurected the em(4) mpsafe diff that got backed out > and I applied the same fix. It is somewhat unclear if this fixes the > watchdog timeouts since in th

Re: Make em(4) more mpsafe again

2015-12-07 Thread Hrvoje Popovski
On 5.12.2015. 15:41, Claudio Jeker wrote: > So Mark and I spent some time to figure out what the issue was with ix(4) > based on that info I resurected the em(4) mpsafe diff that got backed out > and I applied the same fix. It is somewhat unclear if this fixes the > watchdog timeouts since in theor

Make em(4) more mpsafe again

2015-12-05 Thread Claudio Jeker
So Mark and I spent some time to figure out what the issue was with ix(4) based on that info I resurected the em(4) mpsafe diff that got backed out and I applied the same fix. It is somewhat unclear if this fixes the watchdog timeouts since in theory the wdog timer should be stopped when hitting th