Re: NULL checks of static arrays

2016-03-09 Thread Martin Pieuchot
On 08/03/16(Tue) 14:05, Michael McConville wrote: > Martin Pieuchot wrote: > > On 06/03/16(Sun) 19:20, Michael McConville wrote: > > > We check static arrays against NULL pretty often in the kernel. I > > > suspect most of these are due to recent kernel API changes. Should they > > > be removed, or

Re: NULL checks of static arrays

2016-03-08 Thread Michael McConville
Martin Pieuchot wrote: > On 06/03/16(Sun) 19:20, Michael McConville wrote: > > We check static arrays against NULL pretty often in the kernel. I > > suspect most of these are due to recent kernel API changes. Should they > > be removed, or do people want to keep them around in case the APIs > > cha

Re: NULL checks of static arrays

2016-03-07 Thread Martin Pieuchot
On 06/03/16(Sun) 19:20, Michael McConville wrote: > We check static arrays against NULL pretty often in the kernel. I > suspect most of these are due to recent kernel API changes. Should they > be removed, or do people want to keep them around in case the APIs > change again? Clang 3.7 warns about

NULL checks of static arrays

2016-03-06 Thread Michael McConville
We check static arrays against NULL pretty often in the kernel. I suspect most of these are due to recent kernel API changes. Should they be removed, or do people want to keep them around in case the APIs change again? Clang 3.7 warns about them by default, so they're easy to find.