Re: PATCH: Fix PCI Config Space union size on VMM

2020-09-09 Thread Mike Larkin
On Mon, Sep 07, 2020 at 06:03:00PM -0500, Jordan Hargrave wrote: > This code fixes the pci device union for accessing PCI config space >= 0x40 > > Running pcidump -xxx in a virtual machine would return garbage data due to > union overlap > Thanks, looks good from my perspective. -ml > On Mon, S

Re: PATCH: Fix PCI Config Space union size on VMM

2020-09-08 Thread Mark Kettenis
> Date: Mon, 7 Sep 2020 17:52:55 -0500 > From: Jordan Hargrave Yes that would be better. The usage of __packed here is questionable, but that is not your fault. ok kettenis@ > Index: pci.h > === > RCS file: /cvs/src/usr.sbin/vmd/p

Re: PATCH: Fix PCI Config Space union size on VMM

2020-09-07 Thread Jordan Hargrave
This code fixes the pci device union for accessing PCI config space >= 0x40 Running pcidump -xxx in a virtual machine would return garbage data due to union overlap On Mon, Sep 07, 2020 at 05:52:55PM -0500, Jordan Hargrave wrote: > Index: pci.h > =

PATCH: Fix PCI Config Space union size on VMM

2020-09-07 Thread Jordan Hargrave
Index: pci.h === RCS file: /cvs/src/usr.sbin/vmd/pci.h,v retrieving revision 1.7 diff -u -p -u -r1.7 pci.h --- pci.h 17 Sep 2017 23:07:56 - 1.7 +++ pci.h 7 Sep 2020 22:48:09 - @@ -32,43 +32,44 @@ typedef int (*