Re: Patch: Sending credentials over Unix datagram sockets

2020-03-18 Thread David Mackay
Claudio Jeker wrote: > I highly suspect that this is not correct without further changes. > There is a reason why the comment is explicit about the fact that it only > works if SCM_RIGHTS is the only control message type. Just ignoring this > fact is probably a security risk. Isn't the

Re: Patch: Sending credentials over Unix datagram sockets

2020-03-18 Thread Claudio Jeker
On Wed, Mar 18, 2020 at 02:53:14AM -, David Mackay wrote: > Dear openbsd-tech, > > On GNU HURD and FreeBSD, the control message SCM_CREDS may be allocated by a > client of a Unix datagram socket. When the kernel encounters this, it fills > out > a struct cmsgcred containing PID, UID, GID,

Re: Patch: Sending credentials over Unix datagram sockets

2020-03-18 Thread Stuart Henderson
On 2020/03/18 02:53, David Mackay wrote: > Dear openbsd-tech, > > On GNU HURD and FreeBSD, the control message SCM_CREDS may be allocated by a > client of a Unix datagram socket. When the kernel encounters this, it fills > out > a struct cmsgcred containing PID, UID, GID, effective UID, and

Re: Patch: Sending credentials over Unix datagram sockets

2020-03-17 Thread David Mackay
GMail seems determined to ruin the formatting. Diff is now an attachment instead. -Original Message- From: David Mackay Sent: 18 March 2020 03:24 To: 'tech@openbsd.org' Subject: RE: Patch: Sending credentials over Unix datagram sockets Sorry, looks like my mail client mangled

Re: Patch: Sending credentials over Unix datagram sockets

2020-03-17 Thread David Mackay
: Patch: Sending credentials over Unix datagram sockets Dear openbsd-tech, On GNU HURD and FreeBSD, the control message SCM_CREDS may be allocated by a client of a Unix datagram socket. When the kernel encounters this, it fills out a struct cmsgcred containing PID, UID, GID, effective UID

Patch: Sending credentials over Unix datagram sockets

2020-03-17 Thread David Mackay
Dear openbsd-tech, On GNU HURD and FreeBSD, the control message SCM_CREDS may be allocated by a client of a Unix datagram socket. When the kernel encounters this, it fills out a struct cmsgcred containing PID, UID, GID, effective UID, and effective GIDs of the sender. This patch implements this