Re: Patch to add -l flag to cat(1)

2015-07-22 Thread Theo de Raadt
So, what's the story with the -l option? What change/fix in OpenBSD base requires it? Nothing requires it explicitly, more the question of if having the ability for cat to set exclusive locks on its stdout so that multiple calls to the same cat command will cause the the output to be

Re: Patch to add -l flag to cat(1)

2015-07-22 Thread Sevan Janiyan
Hi Philip, On 23/07/2015 00:54, Philip Guenther wrote: This is the second time you've sent a patching adding a feature without saying *why* the feature should be added. That's not very helpful. Apologies. Your first patch for cat added a feature (-f option) to solve problem in NetBSD

Re: Patch to add -l flag to cat(1)

2015-07-22 Thread Philip Guenther
On Wed, Jul 22, 2015 at 4:23 PM, Sevan Janiyan ventur...@geeklan.co.uk wrote: Attached patch adds the -l flag to cat This option causes cat(1) to use fcntl(2) to set an exclusive advisory lock on stdout. which was used to guarantee orderly writing to file. Obtained from NetBSD cat.c r1.26

Patch to add -l flag to cat(1)

2015-07-22 Thread Sevan Janiyan
Hi, Attached patch adds the -l flag to cat This option causes cat(1) to use fcntl(2) to set an exclusive advisory lock on stdout. which was used to guarantee orderly writing to file. Obtained from NetBSD cat.c r1.26 Sevan Janiyan From NetBSD cat.c r1.32 cat.1 r1.26 Index: bin/cat/cat.1