Re: Please test: switch select(2) to kqfilters

2020-10-30 Thread Martin Pieuchot
On 26/10/20(Mon) 11:57, Scott Cheloha wrote: > On Mon, Oct 12, 2020 at 11:11:36AM +0200, Martin Pieuchot wrote: > [...] > > +/* > > + * Scan the kqueue, blocking if necessary until the target time is reached. > > + * If tsp is NULL we block indefinitely. If tsp->ts_secs/nsecs are both > > + * 0

Re: Please test: switch select(2) to kqfilters

2020-10-26 Thread Scott Cheloha
On Mon, Oct 12, 2020 at 11:11:36AM +0200, Martin Pieuchot wrote: > On 09/10/20(Fri) 10:38, Martin Pieuchot wrote: > > On 02/10/20(Fri) 12:19, Martin Pieuchot wrote: > > > Diff below modifies the internal implementation of {p,}select(2) to > > > query kqfilter handlers instead of poll ones. > > >

Re: Please test: switch select(2) to kqfilters

2020-10-12 Thread Martin Pieuchot
On 09/10/20(Fri) 10:38, Martin Pieuchot wrote: > On 02/10/20(Fri) 12:19, Martin Pieuchot wrote: > > Diff below modifies the internal implementation of {p,}select(2) to > > query kqfilter handlers instead of poll ones. > > > > I deliberately left {p,}poll(2) untouched to ease the transition. > >

Re: Please test: switch select(2) to kqfilters

2020-10-09 Thread Martin Pieuchot
On 02/10/20(Fri) 12:19, Martin Pieuchot wrote: > Diff below modifies the internal implementation of {p,}select(2) to > query kqfilter handlers instead of poll ones. > > I deliberately left {p,}poll(2) untouched to ease the transition. > > This diff includes some kqueue refactoring from visa@.

Re: Please test: switch select(2) to kqfilters

2020-10-04 Thread Scott Cheloha
On Sat, Oct 03, 2020 at 09:09:00AM +0200, Martin Pieuchot wrote: > On 02/10/20(Fri) 19:09, Scott Cheloha wrote: > > On Fri, Oct 02, 2020 at 12:19:35PM +0200, Martin Pieuchot wrote: > > > @@ -635,12 +642,39 @@ sys_kevent(struct proc *p, void *v, regi > > > goto done; > > > } > > > > >

Re: Please test: switch select(2) to kqfilters

2020-10-03 Thread Martin Pieuchot
On 02/10/20(Fri) 19:09, Scott Cheloha wrote: > On Fri, Oct 02, 2020 at 12:19:35PM +0200, Martin Pieuchot wrote: > > @@ -635,12 +642,39 @@ sys_kevent(struct proc *p, void *v, regi > > goto done; > > } > > > > + > > KQREF(kq); > > FRELE(fp, p); > > - error =

Re: Please test: switch select(2) to kqfilters

2020-10-02 Thread Scott Cheloha
On Fri, Oct 02, 2020 at 12:19:35PM +0200, Martin Pieuchot wrote: > > [...] > > I'd like to get this in early in this release cycle, so please test and > report back :o) You removed the resleep logic that accounts for if/when tsleep_nsec(9) returns early. So now select and pselect can return

Please test: switch select(2) to kqfilters

2020-10-02 Thread Martin Pieuchot
Diff below modifies the internal implementation of {p,}select(2) to query kqfilter handlers instead of poll ones. I deliberately left {p,}poll(2) untouched to ease the transition. This diff includes some kqueue refactoring from visa@. It is built on top of the changes that went in during the