Re: Push KERNEL_LOCK() down in pgsigio() and selwakeup()

2020-02-11 Thread Martin Pieuchot
On 09/02/20(Sun) 16:40, Visa Hankala wrote: > [...] > In addition, > IPL_AUDIO is above IPL_MPFLOOR on some architectures. That's because audio interrupt handlers have been considered MP-safe, we now know they aren't 8)

Re: Push KERNEL_LOCK() down in pgsigio() and selwakeup()

2020-02-09 Thread Visa Hankala
On Tue, Feb 04, 2020 at 02:21:02PM +0100, Martin Pieuchot wrote: > void > selwakeup(struct selinfo *sip) > { > + KERNEL_LOCK(); > + KNOTE(&sip->si_note, NOTE_SUBMIT); > + doselwakeup(sip); > + KERNEL_UNLOCK(); > +} There is a problem with audio code. Audio interrupt handlers gen

Re: Push KERNEL_LOCK() down in pgsigio() and selwakeup()

2020-02-08 Thread Visa Hankala
On Tue, Feb 04, 2020 at 02:21:02PM +0100, Martin Pieuchot wrote: > As recently profiled, the softnet thread which runs mostly without > KERNEL_LOCK() is still somehow serialized with the rest of the kernel. > This is because the various subsystems to notify userland, either via > poll(2)/select(2),

Push KERNEL_LOCK() down in pgsigio() and selwakeup()

2020-02-04 Thread Martin Pieuchot
As recently profiled, the softnet thread which runs mostly without KERNEL_LOCK() is still somehow serialized with the rest of the kernel. This is because the various subsystems to notify userland, either via poll(2)/select(2), kqueue(2) or pgsignal(9) still require this lock. We worked around thi