Re: Rdistd can dump core with cmdspecial

2014-11-08 Thread Philip Guenther
On Fri, Nov 7, 2014 at 7:17 PM, Michael Kennett wrote: > Problem - rdistd can dump core when a distfile contains cmdspecial. ... > This occurs since the buffer cmd in dospecial() [rdistd/server.c] overflows. > The purpose of this buffer is to store the string 'FILES=...; " which > is passed to an

Rdistd can dump core with cmdspecial

2014-11-07 Thread Michael Kennett
Problem - rdistd can dump core when a distfile contains cmdspecial. For example: # mkdir /tmp/rdist.demo && cd /tmp/rdist.demo # cat /root/Distfile.demo /usr/bin -> localhost install /tmp/rdist.demo/files ; cmdspecial "echo The files were: ${FILES:-*-empty-*} > DONE" ; # rdist -f