Re: Recognize Kingston KC3000 NVME SSD

2023-04-25 Thread Jonathan Gray
thanks, committed

On Sat, Apr 22, 2023 at 05:09:28PM +0200, Paul de Weerd wrote:
> ping
> 
> Is this worth it?  Rebased diff at the bottom for convenience
> 
> On Sun, Mar 19, 2023 at 05:12:18PM +0100, Paul de Weerd wrote:
> | I put a Kingston KC3000 NVME SSD[1] in my new machine.  This diff
> | recognizes that device:
> | 
> | Index: pcidevs
> | ===
> | RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> | retrieving revision 1.2026
> | diff -u -p -r1.2026 pcidevs
> | --- pcidevs 19 Mar 2023 09:38:06 -  1.2026
> | +++ pcidevs 19 Mar 2023 16:08:11 -
> | @@ -7010,6 +7010,7 @@ product JMICRON XD_2  0x2394  xD
> |  
> |  /* Kingston */
> |  product KINGSTON A2000 0x2263  A2000
> | +product KINGSTON KC30000x5013  KC3000
> |  product KINGSTON NV2   0x5019  NV2
> |  
> |  /* Kioxia */
> | 
> | dmesg goes from:
> | 
> | nvme0 at pci15 dev 0 function 0 vendor "Kingston", unknown product 0x5013 
> rev 0x01: msix, NVMe 1.4
> | nvme0: KINGSTON SKC3000D2048G, firmware EIFK31.6, serial 50026B76863F2586
> | scsibus1 at nvme0: 2 targets, initiator 0
> | sd0 at scsibus1 targ 1 lun 0: 
> | sd0: 1953514MB, 512 bytes/sector, 4000797360 sectors
> | 
> | to:
> | 
> | nvme0 at pci15 dev 0 function 0 "Kingston KC3000" rev 0x01: msix, NVMe 1.4
> | nvme0: KINGSTON SKC3000D2048G, firmware EIFK31.6, serial 50026B76863F2586
> | scsibus1 at nvme0: 2 targets, initiator 0
> | sd0 at scsibus1 targ 1 lun 0: 
> | sd0: 1953514MB, 512 bytes/sector, 4000797360 sectors
> | 
> | It already works fine, so I'm not sure it's worth the extra bytes
> | added to the kernel.
> | 
> | Paul
> | 
> | [1]: https://www.kingston.com/en/ssd/kc3000-nvme-m2-solid-state-drive
> | 
> | -- 
> | >[<++>-]<+++.>+++[<-->-]<.>+++[<+
> | +++>-]<.>++[<>-]<+.--.[-]
> |  http://www.weirdnet.nl/ 
> | 
> 
> Index: pcidevs
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.2030
> diff -u -p -u -r1.2030 pcidevs
> --- pcidevs   12 Apr 2023 15:56:08 -  1.2030
> +++ pcidevs   22 Apr 2023 15:06:58 -
> @@ -7023,6 +7023,7 @@ product JMICRON XD_20x2394  xD
>  
>  /* Kingston */
>  product KINGSTON A2000   0x2263  A2000
> +product KINGSTON KC3000  0x5013  KC3000
>  product KINGSTON NV2 0x5019  NV2
>  
>  /* Kioxia */
> 
> -- 
> >[<++>-]<+++.>+++[<-->-]<.>+++[<+
> +++>-]<.>++[<>-]<+.--.[-]
>  http://www.weirdnet.nl/ 
> 
> 



Re: Recognize Kingston KC3000 NVME SSD

2023-04-22 Thread Paul de Weerd
ping

Is this worth it?  Rebased diff at the bottom for convenience

On Sun, Mar 19, 2023 at 05:12:18PM +0100, Paul de Weerd wrote:
| I put a Kingston KC3000 NVME SSD[1] in my new machine.  This diff
| recognizes that device:
| 
| Index: pcidevs
| ===
| RCS file: /cvs/src/sys/dev/pci/pcidevs,v
| retrieving revision 1.2026
| diff -u -p -r1.2026 pcidevs
| --- pcidevs   19 Mar 2023 09:38:06 -  1.2026
| +++ pcidevs   19 Mar 2023 16:08:11 -
| @@ -7010,6 +7010,7 @@ product JMICRON XD_20x2394  xD
|  
|  /* Kingston */
|  product KINGSTON A2000   0x2263  A2000
| +product KINGSTON KC3000  0x5013  KC3000
|  product KINGSTON NV2 0x5019  NV2
|  
|  /* Kioxia */
| 
| dmesg goes from:
| 
| nvme0 at pci15 dev 0 function 0 vendor "Kingston", unknown product 0x5013 rev 
0x01: msix, NVMe 1.4
| nvme0: KINGSTON SKC3000D2048G, firmware EIFK31.6, serial 50026B76863F2586
| scsibus1 at nvme0: 2 targets, initiator 0
| sd0 at scsibus1 targ 1 lun 0: 
| sd0: 1953514MB, 512 bytes/sector, 4000797360 sectors
| 
| to:
| 
| nvme0 at pci15 dev 0 function 0 "Kingston KC3000" rev 0x01: msix, NVMe 1.4
| nvme0: KINGSTON SKC3000D2048G, firmware EIFK31.6, serial 50026B76863F2586
| scsibus1 at nvme0: 2 targets, initiator 0
| sd0 at scsibus1 targ 1 lun 0: 
| sd0: 1953514MB, 512 bytes/sector, 4000797360 sectors
| 
| It already works fine, so I'm not sure it's worth the extra bytes
| added to the kernel.
| 
| Paul
| 
| [1]: https://www.kingston.com/en/ssd/kc3000-nvme-m2-solid-state-drive
| 
| -- 
| >[<++>-]<+++.>+++[<-->-]<.>+++[<+
| +++>-]<.>++[<>-]<+.--.[-]
|  http://www.weirdnet.nl/ 
| 

Index: pcidevs
===
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.2030
diff -u -p -u -r1.2030 pcidevs
--- pcidevs 12 Apr 2023 15:56:08 -  1.2030
+++ pcidevs 22 Apr 2023 15:06:58 -
@@ -7023,6 +7023,7 @@ product JMICRON XD_2  0x2394  xD
 
 /* Kingston */
 product KINGSTON A2000 0x2263  A2000
+product KINGSTON KC30000x5013  KC3000
 product KINGSTON NV2   0x5019  NV2
 
 /* Kioxia */

-- 
>[<++>-]<+++.>+++[<-->-]<.>+++[<+
+++>-]<.>++[<>-]<+.--.[-]
 http://www.weirdnet.nl/ 



Recognize Kingston KC3000 NVME SSD

2023-03-19 Thread Paul de Weerd
I put a Kingston KC3000 NVME SSD[1] in my new machine.  This diff
recognizes that device:

Index: pcidevs
===
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.2026
diff -u -p -r1.2026 pcidevs
--- pcidevs 19 Mar 2023 09:38:06 -  1.2026
+++ pcidevs 19 Mar 2023 16:08:11 -
@@ -7010,6 +7010,7 @@ product JMICRON XD_2  0x2394  xD
 
 /* Kingston */
 product KINGSTON A2000 0x2263  A2000
+product KINGSTON KC30000x5013  KC3000
 product KINGSTON NV2   0x5019  NV2
 
 /* Kioxia */

dmesg goes from:

nvme0 at pci15 dev 0 function 0 vendor "Kingston", unknown product 0x5013 rev 
0x01: msix, NVMe 1.4
nvme0: KINGSTON SKC3000D2048G, firmware EIFK31.6, serial 50026B76863F2586
scsibus1 at nvme0: 2 targets, initiator 0
sd0 at scsibus1 targ 1 lun 0: 
sd0: 1953514MB, 512 bytes/sector, 4000797360 sectors

to:

nvme0 at pci15 dev 0 function 0 "Kingston KC3000" rev 0x01: msix, NVMe 1.4
nvme0: KINGSTON SKC3000D2048G, firmware EIFK31.6, serial 50026B76863F2586
scsibus1 at nvme0: 2 targets, initiator 0
sd0 at scsibus1 targ 1 lun 0: 
sd0: 1953514MB, 512 bytes/sector, 4000797360 sectors

It already works fine, so I'm not sure it's worth the extra bytes
added to the kernel.

Paul

[1]: https://www.kingston.com/en/ssd/kc3000-nvme-m2-solid-state-drive

-- 
>[<++>-]<+++.>+++[<-->-]<.>+++[<+
+++>-]<.>++[<>-]<+.--.[-]
 http://www.weirdnet.nl/