Re: Remove 4.3BSD tty compatibility, take 2

2013-12-12 Thread Todd C. Miller
On Thu, 12 Dec 2013 22:03:53 +, Christian Weisgerber wrote: > make build, release, and xenocara are fine. > Full ports build done and remaining fallout fixed. > > Any okays? OK millert@ - todd

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-12 Thread Todd C. Miller
On Tue, 10 Dec 2013 14:49:26 -0700, Theo de Raadt wrote: > > > Noticed TIOCGSID in that list. Don't think that is a 4.3 compat > > > ioctl. Rather a System V compat ioctl. > > > > Well, it's implemented in compat/common/tty_43.c. If we want to save > > it, we need to move it to kern/tty.c:ttio

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-12 Thread Christian Weisgerber
Christian Weisgerber wrote: > New attempt, now that the userland has been cleaned up. This diff > kills the remaining parts of the COMPAT_43 tty handling in the > kernel. (There are some further network-related COMPAT_43 fragments > that are not touched by this.) > > Comments? ok? make build

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Philip Guenther
On Tue, Dec 10, 2013 at 2:14 PM, Mark Kettenis wrote: > Well, we don't actually have tcgetsid(3); only the ioctl that can be > used to implement it. And tcgetsid(3) is an XSI extension, so not a > required POSIX interface. Issue 7 ... The tcgetsid() function is moved from the XSI option

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Marc Espie
On Tue, Dec 10, 2013 at 11:05:01PM +0100, Marc Espie wrote: > > Note that tcgetsid(3) is part of posix 2008... I don't see this as > a noxious interface, so I don't see any reason not to keep it... My bad, it's XSI in posix 2008, but I was reading posix 2013, which has: Issue 7 The tcgetsid() f

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Mark Kettenis
> Date: Tue, 10 Dec 2013 23:05:01 +0100 > From: Marc Espie > > On Tue, Dec 10, 2013 at 10:31:31PM +0100, Mark Kettenis wrote: > > > Date: Tue, 10 Dec 2013 21:48:41 +0100 > > > From: Christian Weisgerber > > > > > > New attempt, now that the userland has been cleaned up. This diff > > > kills t

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Marc Espie
On Tue, Dec 10, 2013 at 10:31:31PM +0100, Mark Kettenis wrote: > > Date: Tue, 10 Dec 2013 21:48:41 +0100 > > From: Christian Weisgerber > > > > New attempt, now that the userland has been cleaned up. This diff > > kills the remaining parts of the COMPAT_43 tty handling in the > > kernel. (There

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Mark Kettenis
> From: Theo de Raadt > Date: Tue, 10 Dec 2013 14:49:26 -0700 > > > > Noticed TIOCGSID in that list. Don't think that is a 4.3 compat > > > ioctl. Rather a System V compat ioctl. > > > > Well, it's implemented in compat/common/tty_43.c. If we want to save > > it, we need to move it to kern/tt

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Theo de Raadt
> > Noticed TIOCGSID in that list. Don't think that is a 4.3 compat > > ioctl. Rather a System V compat ioctl. > > Well, it's implemented in compat/common/tty_43.c. If we want to save > it, we need to move it to kern/tty.c:ttioctl(). Do we? that's a seperate issue. It can be recovered later

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Christian Weisgerber
Mark Kettenis: > Noticed TIOCGSID in that list. Don't think that is a 4.3 compat > ioctl. Rather a System V compat ioctl. Well, it's implemented in compat/common/tty_43.c. If we want to save it, we need to move it to kern/tty.c:ttioctl(). Do we? -- Christian "naddy" Weisgerber

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Mark Kettenis
> Date: Tue, 10 Dec 2013 21:48:41 +0100 > From: Christian Weisgerber > > New attempt, now that the userland has been cleaned up. This diff > kills the remaining parts of the COMPAT_43 tty handling in the > kernel. (There are some further network-related COMPAT_43 fragments > that are not touche

Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Christian Weisgerber
New attempt, now that the userland has been cleaned up. This diff kills the remaining parts of the COMPAT_43 tty handling in the kernel. (There are some further network-related COMPAT_43 fragments that are not touched by this.) Comments? ok? R compat/common/tty_43.c M conf/files M ddb/db_struc