Re: Removing -Wno-format from kernel makefiles, 07/16

2013-07-04 Thread Franco Fichtner
On Jul 4, 2013, at 6:43 PM, Stefan Fritsch  wrote:

> fix: %x instead of %p for int
> 
> ---
> sys/dev/pci/musycc_obsd.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git sys/dev/pci/musycc_obsd.c sys/dev/pci/musycc_obsd.c
> index 25a58d8..0844136 100644
> --- sys/dev/pci/musycc_obsd.c
> +++ sys/dev/pci/musycc_obsd.c
> @@ -215,7 +215,7 @@ musycc_ebus_attach(struct device *parent, struct 
> musycc_softc *esc,
> #endif
> 
>   if (ebus_attach_device(&rom, sc, 0, 0x400) != 0) {
> - printf(": failed to map rom @ %05p\n", 0);
> + printf(": failed to map rom @ %05x\n", 0);

Makes me wonder what benefit this has other than avoiding to type four
more zeros in the format string manually?  ;)

>   goto failed;
>   }
> 
> -- 
> 1.7.6
> 




Removing -Wno-format from kernel makefiles, 07/16

2013-07-04 Thread Stefan Fritsch
 fix: %x instead of %p for int

---
 sys/dev/pci/musycc_obsd.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git sys/dev/pci/musycc_obsd.c sys/dev/pci/musycc_obsd.c
index 25a58d8..0844136 100644
--- sys/dev/pci/musycc_obsd.c
+++ sys/dev/pci/musycc_obsd.c
@@ -215,7 +215,7 @@ musycc_ebus_attach(struct device *parent, struct 
musycc_softc *esc,
 #endif
 
if (ebus_attach_device(&rom, sc, 0, 0x400) != 0) {
-   printf(": failed to map rom @ %05p\n", 0);
+   printf(": failed to map rom @ %05x\n", 0);
goto failed;
}
 
-- 
1.7.6