Re: Suspend/Resume for nvme

2017-05-27 Thread Claudio Jeker
On Sat, May 27, 2017 at 11:05:42AM +0200, Stefan Fritsch wrote: > On Fri, 26 May 2017, Claudio Jeker wrote: > > > Testing it on my X270. I get: > > nvme0: unable to delete q, disabling > > > > Apart from that it seems to work (eventhough without inteldrm not very > > helpful since I lose the disp

Re: Suspend/Resume for nvme

2017-05-27 Thread Theo de Raadt
> We get called twice on suspend, once with DVACT_SUSPEND and once with > DVACT_POWERDOWN. So, here is a patch that does it like in ahci.c an does > everything in the DVACT_POWERDOWN path and nothing in the DVACT_SUSPEND > path. I suppose so. > @@ -469,6 +512,11 @@ nvme_activate(struct nvme_so

Re: Suspend/Resume for nvme

2017-05-27 Thread Stefan Fritsch
On Fri, 26 May 2017, Claudio Jeker wrote: > Testing it on my X270. I get: > nvme0: unable to delete q, disabling > > Apart from that it seems to work (eventhough without inteldrm not very > helpful since I lose the display). Thanks for testing. We get called twice on suspend, once with DVACT_SU

Re: Suspend/Resume for nvme

2017-05-26 Thread Claudio Jeker
On Fri, May 26, 2017 at 01:54:26PM +0200, Stefan Fritsch wrote: > Hi, > > the following diff adds the missing bits to make suspend/resuem work with > nvme. It was done by ehrhardt@ and tested against nvme.c 1.50, but seems > to apply cleanly. > > Unfortunately, I don't have any nvme hardware at

Suspend/Resume for nvme

2017-05-26 Thread Stefan Fritsch
Hi, the following diff adds the missing bits to make suspend/resuem work with nvme. It was done by ehrhardt@ and tested against nvme.c 1.50, but seems to apply cleanly. Unfortunately, I don't have any nvme hardware at the moment in order to test it. Is there anyone who could test it? Cheers,