Hello,

In sys/net/if_spppsubr.c last activity time stamps can be set to
uninitialized values.

Found with clang.

Regards

 Index: sys/net/if_spppsubr.c
===================================================================
RCS file: /cvs/src/sys/net/if_spppsubr.c,v
retrieving revision 1.144
diff -u -p -r1.144 if_spppsubr.c
--- sys/net/if_spppsubr.c       2 Nov 2015 11:19:30 -0000       1.144
+++ sys/net/if_spppsubr.c       9 Nov 2015 07:44:58 -0000
@@ -509,6 +509,7 @@ sppp_input(struct ifnet *ifp, struct mbu
                case PPP_IP:
                        if (sp->state[IDX_IPCP] == STATE_OPENED) {
                                inq = &ipintrq;
+                               getmicrouptime(&tv);
                                sp->pp_last_activity = tv.tv_sec;
                        }
                        break;
@@ -521,6 +522,7 @@ sppp_input(struct ifnet *ifp, struct mbu
                case PPP_IPV6:
                        if (sp->state[IDX_IPV6CP] == STATE_OPENED) {
                                inq = &ip6intrq;
+                               getmicrouptime(&tv);
                                sp->pp_last_activity = tv.tv_sec;
                        }
                        break;

Reply via email to