Re: Unlock 16 network-related syscalls

2018-05-25 Thread Hrvoje Popovski
On 25.5.2018. 10:35, Martin Pieuchot wrote: > Updated diff that should prevent reported hangs, as analyzed by tb@ and > visa@. with this diff i can't reproduce lockup .. tnx ..

Re: Unlock 16 network-related syscalls

2018-05-25 Thread Mathieu -
Theo Buehler wrote: > On Fri, May 25, 2018 at 10:35:35AM +0200, Martin Pieuchot wrote: > > On 22/05/18(Tue) 15:39, Martin Pieuchot wrote: > > > By assuming that `f_data' is immutable, which AFAIK is true for sockets, > > > we can remove the KERNEL_LOCK() from the following syscalls iff files are >

Re: Unlock 16 network-related syscalls

2018-05-25 Thread Theo Buehler
On Fri, May 25, 2018 at 10:35:35AM +0200, Martin Pieuchot wrote: > On 22/05/18(Tue) 15:39, Martin Pieuchot wrote: > > By assuming that `f_data' is immutable, which AFAIK is true for sockets, > > we can remove the KERNEL_LOCK() from the following syscalls iff files are > > refcounted in an MP-safe

Re: Unlock 16 network-related syscalls

2018-05-25 Thread Martin Pieuchot
On 22/05/18(Tue) 15:39, Martin Pieuchot wrote: > By assuming that `f_data' is immutable, which AFAIK is true for sockets, > we can remove the KERNEL_LOCK() from the following syscalls iff files are > refcounted in an MP-safe way. > > This diff includes the EBUSY check in dup2(2) which is

Re: Unlock 16 network-related syscalls

2018-05-24 Thread Mathieu -
Mathieu - wrote: > Mathieu - wrote: > > Martin Pieuchot wrote: > > > On 23/05/18(Wed) 11:14, Hrvoje Popovski wrote: > > > > On 22.5.2018. 17:03, Theo Buehler wrote: > > > > > I applied the diff, made syscalls, then built and installed a new > > > > > kernel. With that, I ran into a reliable

Re: Unlock 16 network-related syscalls

2018-05-24 Thread Mathieu -
Mathieu - wrote: > Martin Pieuchot wrote: > > On 23/05/18(Wed) 11:14, Hrvoje Popovski wrote: > > > On 22.5.2018. 17:03, Theo Buehler wrote: > > > > I applied the diff, made syscalls, then built and installed a new > > > > kernel. With that, I ran into a reliable complete lockup on my x230 by > > >

Re: Unlock 16 network-related syscalls

2018-05-24 Thread Hrvoje Popovski
On 23.5.2018. 15:29, Theo Buehler wrote: > On Wed, May 23, 2018 at 02:39:20PM +0200, Martin Pieuchot wrote: >> On 23/05/18(Wed) 11:14, Hrvoje Popovski wrote: >>> On 22.5.2018. 17:03, Theo Buehler wrote: I applied the diff, made syscalls, then built and installed a new kernel. With that,

Re: Unlock 16 network-related syscalls

2018-05-23 Thread Theo Buehler
On Wed, May 23, 2018 at 02:39:20PM +0200, Martin Pieuchot wrote: > On 23/05/18(Wed) 11:14, Hrvoje Popovski wrote: > > On 22.5.2018. 17:03, Theo Buehler wrote: > > > I applied the diff, made syscalls, then built and installed a new > > > kernel. With that, I ran into a reliable complete lockup on

Re: Unlock 16 network-related syscalls

2018-05-23 Thread Mathieu -
Martin Pieuchot wrote: > On 23/05/18(Wed) 11:14, Hrvoje Popovski wrote: > > On 22.5.2018. 17:03, Theo Buehler wrote: > > > I applied the diff, made syscalls, then built and installed a new > > > kernel. With that, I ran into a reliable complete lockup on my x230 by > > > starting in an xterm > > >

Re: Unlock 16 network-related syscalls

2018-05-23 Thread Martin Pieuchot
On 23/05/18(Wed) 11:14, Hrvoje Popovski wrote: > On 22.5.2018. 17:03, Theo Buehler wrote: > > I applied the diff, made syscalls, then built and installed a new > > kernel. With that, I ran into a reliable complete lockup on my x230 by > > starting in an xterm > > > > # make -j 3 build 2>&1 | tee

Re: Unlock 16 network-related syscalls

2018-05-23 Thread Mathieu -
Martin Pieuchot wrote: > By assuming that `f_data' is immutable, which AFAIK is true for sockets, > we can remove the KERNEL_LOCK() from the following syscalls iff files are > refcounted in an MP-safe way. > > This diff includes the EBUSY check in dup2(2) which is currently required > to avoid

Re: Unlock 16 network-related syscalls

2018-05-23 Thread Hrvoje Popovski
On 22.5.2018. 17:03, Theo Buehler wrote: > I applied the diff, made syscalls, then built and installed a new > kernel. With that, I ran into a reliable complete lockup on my x230 by > starting in an xterm > > # make -j 3 build 2>&1 | tee -a /home/theo/buildlog > > and then navigating firefox to

Re: Unlock 16 network-related syscalls

2018-05-22 Thread Alexander Bluhm
On Tue, May 22, 2018 at 03:39:11PM +0200, Martin Pieuchot wrote: > Tests? Comments? The regression tests pass with this diff on a dual core i386 machine. bluhm > Index: kern/exec_script.c > === > RCS file:

Re: Unlock 16 network-related syscalls

2018-05-22 Thread Theo Buehler
On Tue, May 22, 2018 at 03:39:11PM +0200, Martin Pieuchot wrote: > By assuming that `f_data' is immutable, which AFAIK is true for sockets, > we can remove the KERNEL_LOCK() from the following syscalls iff files are > refcounted in an MP-safe way. > > This diff includes the EBUSY check in dup2(2)

Unlock 16 network-related syscalls

2018-05-22 Thread Martin Pieuchot
By assuming that `f_data' is immutable, which AFAIK is true for sockets, we can remove the KERNEL_LOCK() from the following syscalls iff files are refcounted in an MP-safe way. This diff includes the EBUSY check in dup2(2) which is currently required to avoid races with accept(2) and will later