Re: Using tame() in userland

2015-08-30 Thread Martin Natano
Inline comments below. --- tsort.c 29 Jul 2015 10:42:37 - 1.26 +++ tsort.c 28 Aug 2015 08:03:59 - @@ -798,6 +799,43 @@ find_longest_cycle(struct array *h, stru #define plural(n) ((n) 1 ? s : ) +static void +TAME(int flags, const char *wl[]) +{ + if

Re: Using tame() in userland

2015-08-29 Thread Steven McDonald
Sorry, my terminal seems to be mangling tabs into spaces. Here's a properly copypasted diff: Index: bin/chmod/chmod.c === RCS file: /cvs/src/bin/chmod/chmod.c,v retrieving revision 1.34 diff -u -p -r1.34 chmod.c --- bin/chmod/chmod.c

Re: Using tame() in userland

2015-08-29 Thread Steven McDonald
Hi Theo, I think chmod fits in the cannot be tamed category. tame(2) says of chmod(2) and friends: Setuid/setgid bits do not work, nor can the user or group be changed on a file. This breaks 'chmod u+s'. It might be possible to tame only if it looks like a mode is being set which is

Re: Using tame() in userland

2015-08-29 Thread trondd
On 2015-08-29 06:05, Steven McDonald wrote: I think chmod fits in the cannot be tamed category. tame(2) says of chmod(2) and friends: Setuid/setgid bits do not work, nor can the user or group be changed on a file. This breaks 'chmod u+s'. I ran into this when building Xenocara.

Re: Using tame() in userland

2015-08-28 Thread Marc Espie
have a much more stringent one for tsort. Index: tsort.c === RCS file: /build/data/openbsd/cvs/src/usr.bin/tsort/tsort.c,v retrieving revision 1.26 diff -u -p -r1.26 tsort.c --- tsort.c 29 Jul 2015 10:42:37 - 1.26 +++

Using tame() in userland

2015-08-27 Thread Theo de Raadt
This is for those of you interested in tame, and skilled enough to play along. This is a set of almost 100 diffs to programs in the tree to use tame. These have been done by myself, doug, florian, semarie, and a few other people I forget. I would make a rough guess these changes took about 100