amd64: Check cpu_vendor instead of using CPUID.

2012-04-22 Thread Christiano F. Haesbaert
There's no need for doing that somewhat strange comparison, the rest of the code already uses cpu_vendor. ok ? Index: identcpu.c === RCS file: /cvs/src/sys/arch/amd64/amd64/identcpu.c,v retrieving revision 1.35 diff -d -u -p -r1.35

Re: amd64: Check cpu_vendor instead of using CPUID.

2012-04-22 Thread Franco Fichtner
Just being paranoid... strncmp? And how about consolidating style while at it? ! vs. == 0 - see code bits below change. Franco On 22.04.2012, at 15:12, Christiano F. Haesbaert haesba...@openbsd.org wrote: There's no need for doing that somewhat strange comparison, the rest of the code already

Re: amd64: Check cpu_vendor instead of using CPUID.

2012-04-22 Thread Christiano F. Haesbaert
On Sun, Apr 22, 2012 at 06:36:41PM +0200, Franco Fichtner wrote: Just being paranoid... strncmp? Why ? It's a terminated string vs a string literal, what do you wanna use as the third argument: strlen(AuthenticAmd) ? . 100% pointless. And how about consolidating style while at it? ! vs. == 0

Re: amd64: Check cpu_vendor instead of using CPUID.

2012-04-22 Thread Franco Fichtner
On Apr 22, 2012, at 7:58 PM, Christiano F. Haesbaert wrote: On Sun, Apr 22, 2012 at 06:36:41PM +0200, Franco Fichtner wrote: Just being paranoid... strncmp? Why ? It's a terminated string vs a string literal, what do you wanna use as the third argument: strlen(AuthenticAmd) ? . 100%

Re: amd64: Check cpu_vendor instead of using CPUID.

2012-04-22 Thread Christiano F. Haesbaert
On Sun, Apr 22, 2012 at 09:16:57PM +0200, Franco Fichtner wrote: On Apr 22, 2012, at 7:58 PM, Christiano F. Haesbaert wrote: On Sun, Apr 22, 2012 at 06:36:41PM +0200, Franco Fichtner wrote: Just being paranoid... strncmp? Why ? It's a terminated string vs a string literal, what do you

Re: amd64: Check cpu_vendor instead of using CPUID.

2012-04-22 Thread Franco Fichtner
On Apr 22, 2012, at 9:32 PM, Christiano F. Haesbaert wrote: On Sun, Apr 22, 2012 at 09:16:57PM +0200, Franco Fichtner wrote: On Apr 22, 2012, at 7:58 PM, Christiano F. Haesbaert wrote: On Sun, Apr 22, 2012 at 06:36:41PM +0200, Franco Fichtner wrote: Just being paranoid... strncmp? Why ?