Re: athn@usb: fixup detach panic

2012-11-10 Thread Stefan Sperling
On Sat, Nov 10, 2012 at 03:52:37AM +0100, Mike Belopuhov wrote: On Tue, Nov 06, 2012 at 12:15 +0100, Stefan Sperling wrote: It seems more appropriate to handle this problem entirely within the USB-specific layer of the driver, rather than within dev/ic/athn.c. If loading the firmware

Re: athn@usb: fixup detach panic

2012-11-09 Thread Mike Belopuhov
On Tue, Nov 06, 2012 at 12:15 +0100, Stefan Sperling wrote: On Tue, Nov 06, 2012 at 11:32:19AM +0100, Mike Belopuhov wrote: attach fails early in case there's no firmware, but athn_detach does ieee80211_ifdetach and if_detach regardless of whether ifnet part got setup correctly leading to

athn@usb: fixup detach panic

2012-11-06 Thread Mike Belopuhov
attach fails early in case there's no firmware, but athn_detach does ieee80211_ifdetach and if_detach regardless of whether ifnet part got setup correctly leading to a free of an unallocated memory and a panic. the following diff follows an established practice in the other drivers and fixes the

Re: athn@usb: fixup detach panic

2012-11-06 Thread Stefan Sperling
On Tue, Nov 06, 2012 at 11:32:19AM +0100, Mike Belopuhov wrote: attach fails early in case there's no firmware, but athn_detach does ieee80211_ifdetach and if_detach regardless of whether ifnet part got setup correctly leading to a free of an unallocated memory and a panic. the following