Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Mark Kettenis
Date: Tue, 21 May 2013 17:10:57 +0200 From: Mike Belopuhov m...@belopuhov.com prevent the system from spitting loads of splasserts when bge_watchdog fires. ok? I'd say no. Why is the driver tearing down and reinitializing the dma maps when a watchdog timeout happens? That's just wrong.

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Theo de Raadt
I'd say no. Why is the driver tearing down and reinitializing the dma maps when a watchdog timeout happens? That's just wrong. Because bge_watchdog() simply calls bge_init() to redo everything. It is simply the way the driver was written. During autoconfig, NOWAIT will be OK. bge is not a

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Mike Belopuhov
On 21 May 2013 17:18, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Tue, 21 May 2013 17:10:57 +0200 From: Mike Belopuhov m...@belopuhov.com prevent the system from spitting loads of splasserts when bge_watchdog fires. ok? I'd say no. Why is the driver tearing down and reinitializing

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Mark Kettenis
From: Theo de Raadt dera...@cvs.openbsd.org Date: Tue, 21 May 2013 09:23:04 -0600 I'd say no. Why is the driver tearing down and reinitializing the dma maps when a watchdog timeout happens? That's just wrong. Because bge_watchdog() simply calls bge_init() to redo everything. It is

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread David Gwynne
sad but ok dlg@ On 22/05/2013, at 2:06 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Theo de Raadt dera...@cvs.openbsd.org Date: Tue, 21 May 2013 09:23:04 -0600 I'd say no. Why is the driver tearing down and reinitializing the dma maps when a watchdog timeout happens? That's

Re: bge: use BUS_DMA_NOWIAT in functions called from the timeout

2013-05-21 Thread Theo de Raadt
sad but ok dlg@ On 22/05/2013, at 2:06 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Theo de Raadt dera...@cvs.openbsd.org Date: Tue, 21 May 2013 09:23:04 -0600 I'd say no. Why is the driver tearing down and reinitializing the dma maps when a watchdog timeout happens?