Re: bgpctl show_attr bad length fix

2014-03-18 Thread Florian Obser
Commited, thanks On Tue, Mar 18, 2014 at 08:57:40AM +, rivo nurges wrote: > Hi! > > When show_attr reads data length from provided data it reads carbage > to alen and fails afterwards. This patch fixes the problem by casting > the data to u_char. While at it I noticed data gets assigned twice

Re: bgpctl show_attr bad length fix

2014-03-18 Thread Stuart Henderson
On 2014/03/18 08:57, rivo nurges wrote: > Hi! > > When show_attr reads data length from provided data it reads carbage > to alen and fails afterwards. This patch fixes the problem by casting > the data to u_char. While at it I noticed data gets assigned twice. > > > bgpctl.c: /* bad imsg len how

bgpctl show_attr bad length fix

2014-03-18 Thread rivo nurges
Hi! When show_attr reads data length from provided data it reads carbage to alen and fails afterwards. This patch fixes the problem by casting the data to u_char. While at it I noticed data gets assigned twice. bgpctl.c: /* bad imsg len how can that happen!? */ bgpctl.c: if (alen > len) bgpctl.c