Re: bgpd: improve RTR error handling

2023-01-31 Thread Claudio Jeker
On Tue, Jan 31, 2023 at 12:13:00PM +, Job Snijders wrote: > When the RTR's Session ID changes (for example when the RTR server is > restarted), bgpd would incorreectly branch into the "received %s: bad > msg len:" path. > > The length fields in the RTR PDU error messages are 32-bits, so we >

bgpd: improve RTR error handling

2023-01-31 Thread Job Snijders
When the RTR's Session ID changes (for example when the RTR server is restarted), bgpd would incorreectly branch into the "received %s: bad msg len:" path. The length fields in the RTR PDU error messages are 32-bits, so we should use ntohl() instead of ntohs(). While there, add an additional