Re: catopen(3) improvements

2013-06-02 Thread Stefan Sperling
On Sun, Jun 02, 2013 at 12:57:01PM -0400, vadi...@gmail.com wrote: > On 5/31/13, Stefan Sperling wrote: > > + ru-KOI8-R.msg ru.UTF-8.msg sv.ISO8859-1.msg sv.UTF-8.msg > > Shouldn't it be ru.KOI8-R.msg ? Yes, I spotted and fixed that before commit.

Re: catopen(3) improvements

2013-06-02 Thread vadimou
On 5/31/13, Stefan Sperling wrote: > + ru-KOI8-R.msg ru.UTF-8.msg sv.ISO8859-1.msg sv.UTF-8.msg Shouldn't it be ru.KOI8-R.msg ?

Re: catopen(3) improvements

2013-05-31 Thread Matthew Dempsky
Nice, LGTM. :) ok matthew

Re: catopen(3) improvements

2013-05-31 Thread Stefan Sperling
On Fri, May 31, 2013 at 06:01:14PM -0700, Matthew Dempsky wrote: > In your man page diff, you should make use of .Dv and .Ev to identify > the defines and environment variables. > > Instead of setting FD_CLOEXEC with fcntl(), just use O_CLOEXEC when opening. > > It looks like parse_lang() won't h

Re: catopen(3) improvements

2013-05-31 Thread Alexander Bluhm
On Sat, Jun 01, 2013 at 02:19:26AM +0200, Stefan Sperling wrote: > -NLS= C.msg Pig.msg da.msg de.msg es.msg fi.msg fr.msg nl.msg no.msg ru.msg > sv.msg it.msg > +NLS= C.msg Pig.msg da-ISO8859-1.msg da-UTF-8.msg de-ISO8859-1.msg \ > + de-UTF-8.msg es-ISO8859-1.msg es-UTF-8.msg fi-ISO885

Re: catopen(3) improvements

2013-05-31 Thread Matthew Dempsky
On Fri, May 31, 2013 at 5:43 PM, Stefan Sperling wrote: > Yes. Conversion currently depends on the GNU iconv port. > If iconv existed in base we could use just the UTF-8 source files. Hmm, I see. In that case, I guess committing converted files makes sense. In your man page diff, you should mak

Re: catopen(3) improvements

2013-05-31 Thread Stefan Sperling
On Fri, May 31, 2013 at 05:34:34PM -0700, Matthew Dempsky wrote: > On Fri, May 31, 2013 at 5:19 PM, Stefan Sperling wrote: > > Existing lib/libc/nls/*.msg files are renamed to the names shown in > > the libc/Makefile part of the diff, and new ones are added to support > > the UTF-8 locale (convert

Re: catopen(3) improvements

2013-05-31 Thread Matthew Dempsky
On Fri, May 31, 2013 at 5:19 PM, Stefan Sperling wrote: > Existing lib/libc/nls/*.msg files are renamed to the names shown in > the libc/Makefile part of the diff, and new ones are added to support > the UTF-8 locale (converted from the existing .msg files with iconv). > I'm not including this cha

catopen(3) improvements

2013-05-31 Thread Stefan Sperling
The base system supports localization of error messages in strerror(). catopen(3) is used to read files that contain translated versions of error messages. Currently these files have arbitrary encodings. Most are latin1, one is UTF-8, one is KOI8. These encodings are currently used regardless of l