ugl(4): self-dv_unit fix (Re: cdce(4): sc-cdce_unit)

2013-12-05 Thread SASANO Takayoshi
Hello, if_ugl.c has similar issue, and I think this should be fixed. ok to commit? SASANO Takayoshi u...@mx5.nisiq.net Index: if_ugl.c === RCS file: /cvs/src/sys/dev/usb/if_ugl.c,v retrieving revision 1.2 diff -u -p -r1.2

cdce(4): sc-cdce_unit

2013-12-03 Thread SASANO Takayoshi
Hello, I read sys/dev/usb/if_cdce.c and found sc-cdce_unit is refered but none initializes. Maybe the fix is required like this :- Index: if_cdce.c === RCS file: /cvs/src/sys/dev/usb/if_cdce.c,v retrieving revision 1.57 diff -u -p

Re: cdce(4): sc-cdce_unit

2013-12-03 Thread Theo de Raadt
I read sys/dev/usb/if_cdce.c and found sc-cdce_unit is refered but none initializes. Maybe the fix is required like this :- [...] + sc-cdce_unit = self-dv_unit; I really dislike variables that serve no purpose. The same thing is available straight out of struct device. I've also fixed