Re: changing ffs mount between rw and ro while preserving softdep

2014-08-28 Thread Boudewijn Dijkstra
Op Wed, 27 Aug 2014 20:50:34 +0200 schreef Miod Vallat m...@online.fr: Why not keep the softdep flag when updating rw-ro? E.g. via mount -ur /usr/obj fstab(5) already allows ro+softdep. Because if we were to apply this diff, there would be no way to switch from rw+softdep to rw. That was

Re: changing ffs mount between rw and ro while preserving softdep

2014-08-28 Thread Miod Vallat
Because if we were to apply this diff, there would be no way to switch from rw+softdep to rw. That was already broken; rw-rw is not affected as per the enclosing if-block. Which is why the current way to remove softdep from a filesystem is a rw+softdep - ro - rw transition, which would no

Re: changing ffs mount between rw and ro while preserving softdep

2014-08-28 Thread Boudewijn Dijkstra
Op Thu, 28 Aug 2014 11:51:32 +0200 schreef Miod Vallat m...@online.fr: Because if we were to apply this diff, there would be no way to switch from rw+softdep to rw. That was already broken; rw-rw is not affected as per the enclosing if-block. Which is why the current way to remove softdep

Re: changing ffs mount between rw and ro while preserving softdep

2014-08-28 Thread Miod Vallat
Which is why the current way to remove softdep from a filesystem is a rw+softdep - ro - rw transition, which would no longer work with your diff. It would work, but you'd have to explicitly disable softdep, as one might expect to be required when removing softdep: Oh, indeed. Then it's a

Re: changing ffs mount between rw and ro while preserving softdep

2014-08-28 Thread Paul de Weerd
On Thu, Aug 28, 2014 at 06:27:48PM +, Miod Vallat wrote: | Which is why the current way to remove softdep from a filesystem is a | rw+softdep - ro - rw transition, which would no longer work with your | diff. | | It would work, but you'd have to explicitly disable softdep, as one might |

Re: changing ffs mount between rw and ro while preserving softdep

2014-08-28 Thread Alexander Hall
On 08/28/14 23:06, Paul de Weerd wrote: On Thu, Aug 28, 2014 at 06:27:48PM +, Miod Vallat wrote: | Which is why the current way to remove softdep from a filesystem is a | rw+softdep - ro - rw transition, which would no longer work with your | diff. | | It would work, but you'd have to

changing ffs mount between rw and ro while preserving softdep

2014-08-27 Thread Boudewijn Dijkstra
Why not keep the softdep flag when updating rw-ro? E.g. via mount -ur /usr/obj fstab(5) already allows ro+softdep. --- /usr/src/sys/ufs/ffs/ffs_vfsops.c.orig Wed Aug 27 19:00:31 2014 +++ /usr/src/sys/ufs/ffs/ffs_vfsops.c Wed Aug 27 19:01:19 2014 @@ -218,10 +218,9 @@

Re: changing ffs mount between rw and ro while preserving softdep

2014-08-27 Thread Miod Vallat
Why not keep the softdep flag when updating rw-ro? E.g. via mount -ur /usr/obj fstab(5) already allows ro+softdep. Because if we were to apply this diff, there would be no way to switch from rw+softdep to rw.

Re: changing ffs mount between rw and ro while preserving softdep

2014-08-27 Thread Philip Guenther
On Wed, Aug 27, 2014 at 11:50 AM, Miod Vallat m...@online.fr wrote: Why not keep the softdep flag when updating rw-ro? E.g. via mount -ur /usr/obj fstab(5) already allows ro+softdep. Because if we were to apply this diff, there would be no way to switch from rw+softdep to rw. And what

Re: changing ffs mount between rw and ro while preserving softdep

2014-08-27 Thread STeve Andre'
On 08/27/14 16:59, Philip Guenther wrote: On Wed, Aug 27, 2014 at 11:50 AM, Miod Vallat m...@online.fr wrote: Why not keep the softdep flag when updating rw-ro? E.g. via mount -ur /usr/obj fstab(5) already allows ro+softdep. Because if we were to apply this diff, there would be no way to