check return in x509 vfy

2014-06-18 Thread Ted Unangst
A tiny patch for a giant function. This kind of looks right, based on some other examples in the function, but it's hard to say for sure since this one function (X509_verify_cert; is that important?) has about a dozen different exit points which free or don't free any number of variables, stacks,

Re: check return in x509 vfy

2014-06-18 Thread Miod Vallat
While you're there, all alloc error paths need to free sktmp and whatever else is done at `end:'. But I am not sure the X509_get_pubkey_parameters() needs to be performed upon error as well, despite the code disagreeing with me. I mean, I would investigate, but my glasses just turned dark on me.