Re: clang warning in sys/scsi/st.c

2015-01-08 Thread Todd C. Miller
On Thu, 08 Jan 2015 20:30:11 +0100, Patrick Wildt wrote: > I really do wonder if GCC is doing the right thing there. > It's probably better to just use bp->b_count from a few lines > above instead of accessing cmd->len like that. I agree, currently that check will never be false. - todd

clang warning in sys/scsi/st.c

2015-01-08 Thread Patrick Wildt
Hi, while compiling a kernel with a newer clang version it stumbled upon the following code starting line 1020 in sys/scsi/st.c: struct scsi_rw_tape *cmd; ... /* * Handle "fixed-block-mode" tape drives by using the * block count instead of the length.