Re: clean up disabled 386 code

2017-04-07 Thread Mike Larkin
On Thu, Apr 06, 2017 at 11:55:58AM +0800, Michael W. Bombardieri wrote:
> Hi,
> 
> The code in "#if 0" has been disabled since revision 1.1.
> From what I see netbsd removed it too:
> http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/i386/i386/trap.c.diff?r1=1.237=1.238=date_with_tag=MAIN=h
> 
> - Michael
> 
> 
> Index: src/sys/arch/i386/i386/trap.c
> ===
> RCS file: /cvs/src/sys/arch/i386/i386/trap.c,v
> retrieving revision 1.128
> diff -u -p -u -r1.128 trap.c
> --- src/sys/arch/i386/i386/trap.c 9 Mar 2017 20:31:41 -   1.128
> +++ src/sys/arch/i386/i386/trap.c 6 Apr 2017 03:32:50 -
> @@ -375,11 +375,6 @@ trap(struct trapframe *frame)
>   goto we_re_toast;
>  
>   pcb = >p_addr->u_pcb;
> -#if 0
> - /* XXX - check only applies to 386's and 486's with WP off */
> - if (frame->tf_err & PGEX_P)
> - goto we_re_toast;
> -#endif
>   cr2 = rcr2();
>   KERNEL_LOCK();
>   /* This will only trigger if SMEP is enabled */
> 

thanks, I'll remove this.



clean up disabled 386 code

2017-04-05 Thread Michael W. Bombardieri
Hi,

The code in "#if 0" has been disabled since revision 1.1.
>From what I see netbsd removed it too:
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/i386/i386/trap.c.diff?r1=1.237=1.238=date_with_tag=MAIN=h

- Michael


Index: src/sys/arch/i386/i386/trap.c
===
RCS file: /cvs/src/sys/arch/i386/i386/trap.c,v
retrieving revision 1.128
diff -u -p -u -r1.128 trap.c
--- src/sys/arch/i386/i386/trap.c   9 Mar 2017 20:31:41 -   1.128
+++ src/sys/arch/i386/i386/trap.c   6 Apr 2017 03:32:50 -
@@ -375,11 +375,6 @@ trap(struct trapframe *frame)
goto we_re_toast;
 
pcb = >p_addr->u_pcb;
-#if 0
-   /* XXX - check only applies to 386's and 486's with WP off */
-   if (frame->tf_err & PGEX_P)
-   goto we_re_toast;
-#endif
cr2 = rcr2();
KERNEL_LOCK();
/* This will only trigger if SMEP is enabled */