Re: diff: Option to use duids in /etc/dumpdates

2014-07-11 Thread Alexander Hall
On 07/11/14 01:15, Maximilian Fillinger wrote: On 07/10/14 16:28, Alexander Hall wrote: Anyway, I worked on your diff a bit more: - keep having -U and -u separate (as discussed) - use Uflag instead of duidflag - bail out if the duid is all 0. - allow specifying the drive to dump by duid.part

Re: diff: Option to use duids in /etc/dumpdates

2014-07-11 Thread Maximilian Fillinger
On Fri, 2014-07-11 at 14:22 +0200, Alexander Hall wrote: If there are no other objections, I'd like to commit this today. Just don't forget to get rid of this + } else { fprintf(stderr, duid: %s\n, duid); } before committing.

Re: diff: Option to use duids in /etc/dumpdates

2014-07-11 Thread Alexander Hall
On 07/11/14 14:33, Maximilian Fillinger wrote: On Fri, 2014-07-11 at 14:22 +0200, Alexander Hall wrote: If there are no other objections, I'd like to commit this today. Just don't forget to get rid of this + } else { fprintf(stderr, duid: %s\n, duid); } before committing. Hmm...

Re: diff: Option to use duids in /etc/dumpdates

2014-07-10 Thread Alexander Hall
On 07/09/14 23:44, Alexander Hall wrote: While looking at this, I noticed we don't support specifying the duid for the device to dump. Thinking a bit more, I'm forming a different approach for this. Hold on. Hm, the different approach was left out because of the messy argument parsing. Bah.

Re: diff: Option to use duids in /etc/dumpdates

2014-07-10 Thread Claudio Jeker
On Thu, Jul 10, 2014 at 04:28:49PM +0200, Alexander Hall wrote: On 07/09/14 23:44, Alexander Hall wrote: While looking at this, I noticed we don't support specifying the duid for the device to dump. Thinking a bit more, I'm forming a different approach for this. Hold on. Hm, the

Re: diff: Option to use duids in /etc/dumpdates

2014-07-10 Thread Maximilian Fillinger
On 07/10/14 18:38, Claudio Jeker wrote: I was looking for something like this. Manly to make dump -W work with DUIDs. Would be nice if it would not introduce a new flag but I think I can live with that if the rest works. How would you decide whether to use the file name or the duid then? I

Re: diff: Option to use duids in /etc/dumpdates

2014-07-09 Thread Alexander Hall
On 07/08/14 19:36, Maximilian Fillinger wrote: Hi! This diff adds a -U flag to dump that allows using disklabel UIDs in /etc/dumpdates. That makes incremental dumps possible when a disk is roaming between device files. I like the idea. I would have liked to read an explanation for the

Re: diff: Option to use duids in /etc/dumpdates

2014-07-09 Thread Maximilian Fillinger
Thanks for your feedback! I like the idea. I would have liked to read an explanation for the selected solution though, or a brief description of it. I'll add a description below for the benefit of other readers. I think adding a check to make sure there is a nonzero duid [...] is

Re: diff: Option to use duids in /etc/dumpdates

2014-07-09 Thread Alexander Hall
On 07/09/14 21:13, Maximilian Fillinger wrote: Thanks for your feedback! I like the idea. I would have liked to read an explanation for the selected solution though, or a brief description of it. I'll add a description below for the benefit of other readers. I think adding a check to make

diff: Option to use duids in /etc/dumpdates

2014-07-08 Thread Maximilian Fillinger
Hi! This diff adds a -U flag to dump that allows using disklabel UIDs in /etc/dumpdates. That makes incremental dumps possible when a disk is roaming between device files. I'd be happy to receive comments. Also, sorry for the noise in misc, and thanks to everyone pointing me in the right