Re: document patch(1) not supporting binary diffs

2021-12-21 Thread Jason McIntyre
On Tue, Dec 21, 2021 at 09:43:27AM +0100, Ingo Schwarze wrote: > Jason McIntyre wrote on Mon, Dec 20, 2021 at 04:13:19PM +: > > > i'm ok with your diff > > Thanks for checking. > > > but it is slightly misleading in context of > > reading from stdin. i suppose that is no biggie. > > I think

Re: document patch(1) not supporting binary diffs

2021-12-21 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Mon, Dec 20, 2021 at 10:37:00AM -0700: > Ingo Schwarze wrote: >> The patch(1) manual talks about "lines" throughout, >> and for binary files, a concept of "lines" does not even exist. > That is a bit strong. Some utilities designed for "text files" have no > pro

Re: document patch(1) not supporting binary diffs

2021-12-21 Thread Ingo Schwarze
Jason McIntyre wrote on Mon, Dec 20, 2021 at 04:13:19PM +: > i'm ok with your diff Thanks for checking. > but it is slightly misleading in context of > reading from stdin. i suppose that is no biggie. I think i see why you say so. Speaking *formally*, what we usually do is describing what

Re: document patch(1) not supporting binary diffs

2021-12-20 Thread Theo de Raadt
Ingo Schwarze wrote: > The patch(1) manual talks about "lines" throughout, > and for binary files, a concept of "lines" does not even exist. That is a bit strong. Some utilities designed for "text files" have no problem being both 8-bit clean and very-long-line capable. For example, you can us

Re: document patch(1) not supporting binary diffs

2021-12-20 Thread Jason McIntyre
On Mon, Dec 20, 2021 at 04:45:58PM +0100, Ingo Schwarze wrote: > Hi Christopher, > > Christopher Zimmermann wrote on Mon, Dec 20, 2021 at 04:01:49PM +0100: > > > base patch cannot work with diffs of binary files. It might help to say > > so in the manpage since other implementations do support t

Re: document patch(1) not supporting binary diffs

2021-12-20 Thread Ingo Schwarze
Hi Christopher, Christopher Zimmermann wrote on Mon, Dec 20, 2021 at 04:01:49PM +0100: > base patch cannot work with diffs of binary files. It might help to say > so in the manpage since other implementations do support this (ab)use of > patch. OK? I agree you are pointing out a slight problem

document patch(1) not supporting binary diffs

2021-12-20 Thread Christopher Zimmermann
Hi, base patch cannot work with diffs of binary files. It might help to say so in the manpage since other implementations do support this (ab)use of patch. OK? Christopher Index: patch.1 === RCS file: /cvs/src/usr.bin/patch/pa