Re: Another dwiic(4) fix

2019-08-17 Thread Mike Larkin
On Sat, Aug 17, 2019 at 06:42:01PM +0200, Mark Kettenis wrote: > The timeout when waiting for data to be received for polled mode is > too small for taling to the BMC on the Ampere/Lenovo arm64 server. > This bumps it to 50 ms, which is still lower than what it is for > non-polled mode. > > I

Another dwiic(4) fix

2019-08-17 Thread Mark Kettenis
The timeout when waiting for data to be received for polled mode is too small for taling to the BMC on the Ampere/Lenovo arm64 server. This bumps it to 50 ms, which is still lower than what it is for non-polled mode. I also found that things worked much better if we checked for the actually STOP

Re: dwiic(4) fix

2018-05-24 Thread Bobby Johnson
My iatp device works the same as before, good on boot, but fails reading main memory map, etc on resume. On Wed, May 23, 2018 at 11:18 PM, Mike Larkin wrote: > On Tue, May 22, 2018 at 05:43:01PM +0200, Mark Kettenis wrote: >> > Date: Mon, 21 May 2018 17:25:47 -0700 >> >

Re: dwiic(4) fix

2018-05-23 Thread Mike Larkin
On Tue, May 22, 2018 at 05:43:01PM +0200, Mark Kettenis wrote: > > Date: Mon, 21 May 2018 17:25:47 -0700 > > From: Mike Larkin > > > > On Mon, May 21, 2018 at 12:44:47PM +0200, Mark Kettenis wrote: > > > The diff below fixes I2C_OP_WRITE_WITH_STOP operations. Currently we

Re: dwiic(4) fix

2018-05-22 Thread Remi Locherer
On Tue, May 22, 2018 at 05:43:01PM +0200, Mark Kettenis wrote: > > Date: Mon, 21 May 2018 17:25:47 -0700 > > From: Mike Larkin > > > > On Mon, May 21, 2018 at 12:44:47PM +0200, Mark Kettenis wrote: > > > The diff below fixes I2C_OP_WRITE_WITH_STOP operations. Currently we

Re: dwiic(4) fix

2018-05-22 Thread Mark Kettenis
> Date: Mon, 21 May 2018 17:25:47 -0700 > From: Mike Larkin > > On Mon, May 21, 2018 at 12:44:47PM +0200, Mark Kettenis wrote: > > The diff below fixes I2C_OP_WRITE_WITH_STOP operations. Currently we > > run the read completion code for those operations, but since there is

Re: dwiic(4) fix

2018-05-21 Thread Mike Larkin
On Mon, May 21, 2018 at 12:44:47PM +0200, Mark Kettenis wrote: > The diff below fixes I2C_OP_WRITE_WITH_STOP operations. Currently we > run the read completion code for those operations, but since there is > no data to read, this fails. Instead, this waits until a stop is > detected. That

dwiic(4) fix

2018-05-21 Thread Mark Kettenis
The diff below fixes I2C_OP_WRITE_WITH_STOP operations. Currently we run the read completion code for those operations, but since there is no data to read, this fails. Instead, this waits until a stop is detected. That doesn't seem to work for I2C_F_POLL operations though, so in that case we