Re: em(4) IPv4, TCP, UDP checksum offloading

2022-11-05 Thread Moritz Buhl
Looking for OKs. On Sat, Oct 15, 2022 at 10:01:53PM +0200, Moritz Buhl wrote: > With the previous diffs I am seeing sporadic connection problems in tcpbench > via IPv6 on Intel 82546GB. > The diff was too big anyways. Here is a smaller diff that introduces > checksum offloading for the

Re: em(4) IPv4, TCP, UDP checksum offloading

2022-10-18 Thread Hrvoje Popovski
On 15.10.2022. 22:01, Moritz Buhl wrote: > With the previous diffs I am seeing sporadic connection problems in tcpbench > via IPv6 on Intel 82546GB. > The diff was too big anyways. Here is a smaller diff that introduces > checksum offloading for the controllers that use the advanced descriptors. >

Re: em(4) IPv4, TCP, UDP checksum offloading

2022-10-15 Thread Moritz Buhl
With the previous diffs I am seeing sporadic connection problems in tcpbench via IPv6 on Intel 82546GB. The diff was too big anyways. Here is a smaller diff that introduces checksum offloading for the controllers that use the advanced descriptors. I tested this diff on i350 and 82571EB, receive,

Re: em(4) IPv4, TCP, UDP checksum offloading

2022-10-12 Thread Moritz Buhl
Another mistake On Wed, Oct 12, 2022 at 01:45:30PM +0200, Moritz Buhl wrote: > On Tue, Oct 11, 2022 at 04:16:15PM +0100, Stuart Henderson wrote: > > On 2022/10/11 15:03, Moritz Buhl wrote: > > > Here is a new diff for checksum offloading (ipv4, udp, tcp) for em(4). > > > > > > The previous diff

Re: em(4) IPv4, TCP, UDP checksum offloading

2022-10-12 Thread Moritz Buhl
On Tue, Oct 11, 2022 at 04:16:15PM +0100, Stuart Henderson wrote: > On 2022/10/11 15:03, Moritz Buhl wrote: > > Here is a new diff for checksum offloading (ipv4, udp, tcp) for em(4). > > > > The previous diff didn't implement hardware vlan tagging for >em82578 > > which should result in variable

Re: em(4) IPv4, TCP, UDP checksum offloading

2022-10-11 Thread Hrvoje Popovski
On 11.10.2022. 17:16, Stuart Henderson wrote: Hi, > I tried this on my laptop which has I219-V em (I run it in a trunk > with iwm). It breaks tx (packets don't show up on the other side). > rx seems ok. > > There is also a "em0: watchdog: head 111 tail 20 TDH 20 TDT 111" this em log can be

Re: em(4) IPv4, TCP, UDP checksum offloading

2022-10-11 Thread Hrvoje Popovski
On 11.10.2022. 15:03, Moritz Buhl wrote: > Here is a new diff for checksum offloading (ipv4, udp, tcp) for em(4). > > The previous diff didn't implement hardware vlan tagging for >em82578 > which should result in variable ethernet header lengths and thus > wrong checksums inserted at wrong

Re: em(4) IPv4, TCP, UDP checksum offloading

2022-10-11 Thread Stuart Henderson
On 2022/10/11 15:03, Moritz Buhl wrote: > Here is a new diff for checksum offloading (ipv4, udp, tcp) for em(4). > > The previous diff didn't implement hardware vlan tagging for >em82578 > which should result in variable ethernet header lengths and thus > wrong checksums inserted at wrong places.

em(4) IPv4, TCP, UDP checksum offloading

2022-10-11 Thread Moritz Buhl
Here is a new diff for checksum offloading (ipv4, udp, tcp) for em(4). The previous diff didn't implement hardware vlan tagging for >em82578 which should result in variable ethernet header lengths and thus wrong checksums inserted at wrong places. The diff below addresses this. I would