Re: enum unsigned or not?

2017-08-31 Thread Tom Cosgrove
>>> patrick keshishian 31-Aug-17 20:40 >>> > > On Thu, Aug 31, 2017 at 12:13:19PM -0700, William Ahern wrote: > > On Thu, Aug 31, 2017 at 02:08:07PM +0200, Otto Moerbeek wrote: > > > Hi, > > > > > > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of > > > unsigned enum expression < 0

Re: enum unsigned or not?

2017-08-31 Thread patrick keshishian
On Thu, Aug 31, 2017 at 12:13:19PM -0700, William Ahern wrote: > On Thu, Aug 31, 2017 at 02:08:07PM +0200, Otto Moerbeek wrote: > > Hi, > > > > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of > > unsigned enum expression < 0 is always false [-Wtautological-compare] > > if (

Re: enum unsigned or not?

2017-08-31 Thread William Ahern
On Thu, Aug 31, 2017 at 02:08:07PM +0200, Otto Moerbeek wrote: > Hi, > > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of > unsigned enum expression < 0 is always false [-Wtautological-compare] > if (state < 0 || state > FAIL) > ~ ^ ~ > /usr/src/usr.sbin/sasy

Re: enum unsigned or not?

2017-08-31 Thread Otto Moerbeek
On Thu, Aug 31, 2017 at 05:10:27PM +0200, Boudewijn Dijkstra wrote: > Op Thu, 31 Aug 2017 14:08:07 +0200 schreef Otto Moerbeek : > > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of > > unsigned enum expression < 0 is always false [-Wtautological-compare] > > if (state < 0 |

Re: enum unsigned or not?

2017-08-31 Thread Boudewijn Dijkstra
Op Thu, 31 Aug 2017 14:08:07 +0200 schreef Otto Moerbeek : /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of unsigned enum expression < 0 is always false [-Wtautological-compare] if (state < 0 || state > FAIL) ~ ^ ~ /usr/src/usr.sbin/sasyncd/carp.c:166:20: wa

enum unsigned or not?

2017-08-31 Thread Otto Moerbeek
Hi, /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of unsigned enum expression < 0 is always false [-Wtautological-compare] if (state < 0 || state > FAIL) ~ ^ ~ /usr/src/usr.sbin/sasyncd/carp.c:166:20: warning: comparison of unsigned enum expression < 0 is alw