Re: explicitly check broadcast addresses on some ifa_ifwithaddr() uses

2015-12-03 Thread Vincent Gross
On 12/02/15 20:06, Martin Pieuchot wrote: > On 02/12/15(Wed) 16:18, Vincent Gross wrote: >> When fed a broadcast address, ifa_ifwitaddr() returns the unicast ifa >> whose broadcast address match the input. This is used mainly to select >> ifa, and there can be trouble when you have 2 ifas on the

Re: explicitly check broadcast addresses on some ifa_ifwithaddr() uses

2015-12-03 Thread Vincent Gross
On 12/03/15 10:21, Vincent Gross wrote: > On 12/02/15 20:06, Martin Pieuchot wrote: >> On 02/12/15(Wed) 16:18, Vincent Gross wrote: >>> When fed a broadcast address, ifa_ifwitaddr() returns the unicast ifa >>> whose broadcast address match the input. This is used mainly to select >>> ifa, and

Re: explicitly check broadcast addresses on some ifa_ifwithaddr() uses

2015-12-03 Thread Alexander Bluhm
On Thu, Dec 03, 2015 at 02:52:59PM +0100, Vincent Gross wrote: > bluhm@ spotted one case where in_broadcast was needed. > > ok ? OK bluhm@ > > Index: sys/net/if.c > === > RCS file: /cvs/src/sys/net/if.c,v > retrieving revision

explicitly check broadcast addresses on some ifa_ifwithaddr() uses

2015-12-02 Thread Vincent Gross
When fed a broadcast address, ifa_ifwitaddr() returns the unicast ifa whose broadcast address match the input. This is used mainly to select ifa, and there can be trouble when you have 2 ifas on the same range (e.g. 10.0.0.1/24@em0 & 10.0.0.20/24@em1) : netinet/ip_mroute.c:814 net/route.c:785

Re: explicitly check broadcast addresses on some ifa_ifwithaddr() uses

2015-12-02 Thread Martin Pieuchot
On 02/12/15(Wed) 16:18, Vincent Gross wrote: > When fed a broadcast address, ifa_ifwitaddr() returns the unicast ifa > whose broadcast address match the input. This is used mainly to select > ifa, and there can be trouble when you have 2 ifas on the same range > (e.g. 10.0.0.1/24@em0 &