Re: ftp: don't close fin or s twice

2018-02-06 Thread sunil+tech
Stuart Henderson wrote: > Regarding ftp(1), it would be nice to get more eyes on sunil@'s rewrite, > apart from anything else it fixes problems with some servers (like > ftp.tug.org) > that don't work with the existing code.. Hi, For folks on tech@, the latest code is at https://nimmagadda.net/

Re: ftp: don't close fin or s twice

2018-02-06 Thread Stuart Henderson
Regarding ftp(1), it would be nice to get more eyes on sunil@'s rewrite, apart from anything else it fixes problems with some servers (like ftp.tug.org) that don't work with the existing code..

Re: ftp: don't close fin or s twice

2018-02-05 Thread Theo Buehler
On Tue, Feb 06, 2018 at 03:02:14PM +1300, richard.n.proc...@gmail.com wrote: > > > On Tue, 6 Feb 2018, Theo Buehler wrote: > > > In cleanup_url_get, fin and s will be closed a second time, so mark them > > as invalid after closing them the first time. > > > > Another option might be to remove t

Re: ftp: don't close fin or s twice

2018-02-05 Thread richard . n . procter
On Tue, 6 Feb 2018, Theo Buehler wrote: > In cleanup_url_get, fin and s will be closed a second time, so mark them > as invalid after closing them the first time. > > Another option might be to remove the fclose/close calls, but since this > happens right before the recursive call, I'm not sure

ftp: don't close fin or s twice

2018-02-05 Thread Theo Buehler
In cleanup_url_get, fin and s will be closed a second time, so mark them as invalid after closing them the first time. Another option might be to remove the fclose/close calls, but since this happens right before the recursive call, I'm not sure whether this might run the risk of hitting limits.