Re: if_loop

[Gleydson Soares]

On Fri, Jan 8, 2010 at 9:15 PM, Claudio Jeker 
wrote:
> > On Fri, Jan 08, 2010 at 01:06:03AM -0300, Gleydson Soares wrote:
> >> i guess that if ifp might be bpf attached in loop_clone_create() it
should be detached case destroyed.
> >> Index: if_loop.c
> >> ===
> >> RCS file: /cvs/src/sys/net/if_loop.c,v
> >> retrieving revision 1.44
> >> diff -N -u if_loop.c
> >> --- if_loop.c 7 May 2008 12:58:54 -   1.44
> >> +++ if_loop.c 8 Jan 2010 03:34:17 -
> >> @@ -221,6 +221,9 @@
> >>   if (ifp == lo0ifp)
> >>   return (EPERM);
> >>
> >> +#if NBPFILTER > 0
> >> + bpfdetach(ifp);
> >> +#endif
> >>   if_detach(ifp);
> >>
> >>   free(ifp, M_DEVBUF);
> >>
> >
> > bpfdetach() is called in if_detach(). So there is no need for this diff.
> >
> > --
> > :wq Claudio

sure. my eyes slipped in if.c

Re: if_loop

[Claudio Jeker]

On Fri, Jan 08, 2010 at 01:06:03AM -0300, Gleydson Soares wrote:
> i guess that if ifp might be bpf attached in loop_clone_create() it should be 
> detached case destroyed.
> Index: if_loop.c
> ===
> RCS file: /cvs/src/sys/net/if_loop.c,v
> retrieving revision 1.44
> diff -N -u if_loop.c
> --- if_loop.c 7 May 2008 12:58:54 -   1.44
> +++ if_loop.c 8 Jan 2010 03:34:17 -
> @@ -221,6 +221,9 @@
>   if (ifp == lo0ifp)
>   return (EPERM);
>  
> +#if NBPFILTER > 0
> + bpfdetach(ifp);
> +#endif
>   if_detach(ifp);
>  
>   free(ifp, M_DEVBUF);
> 

bpfdetach() is called in if_detach(). So there is no need for this diff.

-- 
:wq Claudio

if_loop

[Gleydson Soares]

i guess that if ifp might be bpf attached in loop_clone_create() it should be 
detached case destroyed.
Index: if_loop.c
===
RCS file: /cvs/src/sys/net/if_loop.c,v
retrieving revision 1.44
diff -N -u if_loop.c
--- if_loop.c   7 May 2008 12:58:54 -   1.44
+++ if_loop.c   8 Jan 2010 03:34:17 -
@@ -221,6 +221,9 @@
if (ifp == lo0ifp)
return (EPERM);
 
+#if NBPFILTER > 0
+   bpfdetach(ifp);
+#endif
if_detach(ifp);
 
free(ifp, M_DEVBUF);