Re: if_wg: Missing DPRINTF newline

2022-02-20 Thread Theo Buehler 
On Sun, Feb 20, 2022 at 01:50:45PM -0600, Matthew Martin wrote:
> On Thu, Feb 03, 2022 at 07:53:43AM +, Jason McIntyre wrote:
> > On Wed, Feb 02, 2022 at 07:46:39PM -0600, Matthew Martin wrote:
> > > Two DPRINTFs in sys/net/if_wg.c are missing a newline.
> > > 
> > 
> > if this is committed, the committer may also want to question the dodgy
> > capitals in "Delay Unsupported".
> > 
> > jmc
> 
> ping

Committed with lowercase "delay unsupported", thanks

Re: if_wg: Missing DPRINTF newline

2022-02-20 Thread Matthew Martin 
On Thu, Feb 03, 2022 at 07:53:43AM +, Jason McIntyre wrote:
> On Wed, Feb 02, 2022 at 07:46:39PM -0600, Matthew Martin wrote:
> > Two DPRINTFs in sys/net/if_wg.c are missing a newline.
> > 
> 
> if this is committed, the committer may also want to question the dodgy
> capitals in "Delay Unsupported".
> 
> jmc

ping


diff --git if_wg.c if_wg.c
index 13c48f42c54..a3efd577dbc 100644
--- if_wg.c
+++ if_wg.c
@@ -2156,7 +2156,7 @@ wg_output(struct ifnet *ifp, struct mbuf *m, struct 
sockaddr *sa,
}
 
if (m->m_pkthdr.ph_loopcnt++ > M_MAXLOOP) {
-   DPRINTF(sc, "Packet looped");
+   DPRINTF(sc, "Packet looped\n");
ret = ELOOP;
goto error;
}
@@ -2169,7 +2169,7 @@ wg_output(struct ifnet *ifp, struct mbuf *m, struct 
sockaddr *sa,
 * another aip_lookup in wg_qstart, or refcnting as mentioned before.
 */
if (m->m_pkthdr.pf.delay > 0) {
-   DPRINTF(sc, "PF Delay Unsupported");
+   DPRINTF(sc, "PF Delay Unsupported\n");
ret = EOPNOTSUPP;
goto error;
}

Re: if_wg: Missing DPRINTF newline

2022-02-02 Thread Jason McIntyre 
On Wed, Feb 02, 2022 at 07:46:39PM -0600, Matthew Martin wrote:
> Two DPRINTFs in sys/net/if_wg.c are missing a newline.
> 

if this is committed, the committer may also want to question the dodgy
capitals in "Delay Unsupported".

jmc

> 
> diff --git if_wg.c if_wg.c
> index 13c48f42c54..a3efd577dbc 100644
> --- if_wg.c
> +++ if_wg.c
> @@ -2156,7 +2156,7 @@ wg_output(struct ifnet *ifp, struct mbuf *m, struct 
> sockaddr *sa,
>   }
>  
>   if (m->m_pkthdr.ph_loopcnt++ > M_MAXLOOP) {
> - DPRINTF(sc, "Packet looped");
> + DPRINTF(sc, "Packet looped\n");
>   ret = ELOOP;
>   goto error;
>   }
> @@ -2169,7 +2169,7 @@ wg_output(struct ifnet *ifp, struct mbuf *m, struct 
> sockaddr *sa,
>* another aip_lookup in wg_qstart, or refcnting as mentioned before.
>*/
>   if (m->m_pkthdr.pf.delay > 0) {
> - DPRINTF(sc, "PF Delay Unsupported");
> + DPRINTF(sc, "PF Delay Unsupported\n");
>   ret = EOPNOTSUPP;
>   goto error;
>   }
>

if_wg: Missing DPRINTF newline

2022-02-02 Thread Matthew Martin 
Two DPRINTFs in sys/net/if_wg.c are missing a newline.


diff --git if_wg.c if_wg.c
index 13c48f42c54..a3efd577dbc 100644
--- if_wg.c
+++ if_wg.c
@@ -2156,7 +2156,7 @@ wg_output(struct ifnet *ifp, struct mbuf *m, struct 
sockaddr *sa,
}
 
if (m->m_pkthdr.ph_loopcnt++ > M_MAXLOOP) {
-   DPRINTF(sc, "Packet looped");
+   DPRINTF(sc, "Packet looped\n");
ret = ELOOP;
goto error;
}
@@ -2169,7 +2169,7 @@ wg_output(struct ifnet *ifp, struct mbuf *m, struct 
sockaddr *sa,
 * another aip_lookup in wg_qstart, or refcnting as mentioned before.
 */
if (m->m_pkthdr.pf.delay > 0) {
-   DPRINTF(sc, "PF Delay Unsupported");
+   DPRINTF(sc, "PF Delay Unsupported\n");
ret = EOPNOTSUPP;
goto error;
}