Re: ifmedia_ioctl: ignore ENETRESET from ifm_change()

2019-04-24 Thread Peter Hessler
On 2019 Apr 24 (Wed) at 22:50:58 +1000 (+1000), Jonathan Matthew wrote: :On Wed, Apr 24, 2019 at 12:21:47PM +0200, Stefan Sperling wrote: :> On Sun, Apr 21, 2019 at 09:44:08PM +0800, Kevin Lo wrote: :> > On Sun, Apr 21, 2019 at 01:02:39PM +1000, Jonathan Matthew wrote: :> > > Currently we have some

Re: ifmedia_ioctl: ignore ENETRESET from ifm_change()

2019-04-24 Thread Jonathan Matthew
On Wed, Apr 24, 2019 at 12:21:47PM +0200, Stefan Sperling wrote: > On Sun, Apr 21, 2019 at 09:44:08PM +0800, Kevin Lo wrote: > > On Sun, Apr 21, 2019 at 01:02:39PM +1000, Jonathan Matthew wrote: > > > Currently we have some drivers with media_change > > > functions returning the errno from ieee8021

Re: ifmedia_ioctl: ignore ENETRESET from ifm_change()

2019-04-24 Thread Stefan Sperling
On Sun, Apr 21, 2019 at 09:44:08PM +0800, Kevin Lo wrote: > On Sun, Apr 21, 2019 at 01:02:39PM +1000, Jonathan Matthew wrote: > > Currently we have some drivers with media_change > > functions returning the errno from ieee80211_media_change (iwn, iwm) and > > some > > just returning 0 at the end (

Re: ifmedia_ioctl: ignore ENETRESET from ifm_change()

2019-04-21 Thread Kevin Lo
On Sun, Apr 21, 2019 at 01:02:39PM +1000, Jonathan Matthew wrote: > > On Mon, Apr 15, 2019 at 04:48:02PM +0200, Stefan Sperling wrote: > > ieee80211_media_change() will return ENETRESET if the interface is > > switched into 11a/b/g/n mode from any other mode. > > ifmedia_ioctl() considers this an

Re: ifmedia_ioctl: ignore ENETRESET from ifm_change()

2019-04-20 Thread Jonathan Matthew
On Mon, Apr 15, 2019 at 04:48:02PM +0200, Stefan Sperling wrote: > ieee80211_media_change() will return ENETRESET if the interface is > switched into 11a/b/g/n mode from any other mode. > ifmedia_ioctl() considers this an error and reverts ifmedia's state > to the previous setting, even though net8

ifmedia_ioctl: ignore ENETRESET from ifm_change()

2019-04-15 Thread Stefan Sperling
ieee80211_media_change() will return ENETRESET if the interface is switched into 11a/b/g/n mode from any other mode. ifmedia_ioctl() considers this an error and reverts ifmedia's state to the previous setting, even though net80211 has actually succeeded. The result is that if_media and net80211 hav