Re: initialize variables patch for bn_nist.c

2016-07-17 Thread Ted Unangst
Brent Cook wrote: > I didn't notice it at first, because the patch wasn't inline, but the union > here needed to be initialized with memset or use a different kind of > initializer. > > I went with the memset on top of your patch: > > --- bn_nist.c 17 Jul 2016 21:21:40 - 1.16 > +++ bn_

Re: initialize variables patch for bn_nist.c

2016-07-17 Thread Brent Cook
I didn't notice it at first, because the patch wasn't inline, but the union here needed to be initialized with memset or use a different kind of initializer. I went with the memset on top of your patch: --- bn_nist.c 17 Jul 2016 21:21:40 - 1.16 +++ bn_nist.c 17 Jul 2016 22:00:45 -000

Re: initialize variables patch for bn_nist.c

2016-07-14 Thread Bob Beck
I'm ok with this. On Thu, Jul 14, 2016 at 4:57 AM, Kinichiro Inoguchi < kinichiro.inogu...@gmail.com> wrote: > Hi, > > When I build LibreSSL portable on HP-UX 11.3 with HP C/aC++ compiler, > this warning is detected. > > ... > "bn/bn_nist.c", line 611: warning #2549-D: variable "buf" is used bef

initialize variables patch for bn_nist.c

2016-07-14 Thread Kinichiro Inoguchi
Hi, When I build LibreSSL portable on HP-UX 11.3 with HP C/aC++ compiler, this warning is detected. ... "bn/bn_nist.c", line 611: warning #2549-D: variable "buf" is used before its value is set nist_set_224(buf.bn, c_d, 14, 13, 12, 11, 10, 9, 8); ^ ... To initialize these variables before using