Re: install.sub: No need for subshell in feed_random()

2017-07-01 Thread Theo de Raadt
> It agree that it my not seem reasonable enough (to you), but there is a > technical point to it. Well, maybe you'll get to it eventually.

Re: install.sub: No need for subshell in feed_random()

2017-07-01 Thread Klemens Nanni
On Sat, Jul 01, 2017 at 11:17:55PM -0600, Theo de Raadt wrote: On Sat, Jul 01, 2017 at 11:01:00PM -0600, Theo de Raadt wrote: >Don't understand your point. What is this fixing? Nothing gets "fixed", it just avoids unnecessary forking and makes clear that the inner commands do not require a

Re: install.sub: No need for subshell in feed_random()

2017-07-01 Thread Theo de Raadt
> On Sat, Jul 01, 2017 at 11:01:00PM -0600, Theo de Raadt wrote: > >Don't understand your point. What is this fixing? > Nothing gets "fixed", it just avoids unnecessary forking and makes clear > that the inner commands do not require a subshell - there are no side > effects on the environment so

Re: install.sub: No need for subshell in feed_random()

2017-07-01 Thread Klemens Nanni
On Sat, Jul 01, 2017 at 10:13:45PM -0700, Philip Guenther wrote: I've lost track of how many times at work and in OpenBSD I've tested a diff, made a final modification and then committed...a change broken by that final modification. Once you've tested a diff, either don't make a "this is easy!"

Re: install.sub: No need for subshell in feed_random()

2017-07-01 Thread Philip Guenther
On Sat, Jul 1, 2017 at 9:47 PM, Klemens Nanni wrote: > On Sat, Jul 01, 2017 at 09:35:09PM -0700, Philip Guenther wrote: >> >> On Sat, Jul 1, 2017 at 9:27 PM, Klemens Nanni wrote: >>> >>> A simple command list suffices as this is just about redirecting all >>>

Re: install.sub: No need for subshell in feed_random()

2017-07-01 Thread Klemens Nanni
On Sat, Jul 01, 2017 at 11:01:00PM -0600, Theo de Raadt wrote: Don't understand your point. What is this fixing? Nothing gets "fixed", it just avoids unnecessary forking and makes clear that the inner commands do not require a subshell - there are no side effects on the environment so a

Re: install.sub: No need for subshell in feed_random()

2017-07-01 Thread Theo de Raadt
Don't understand your point. What is this fixing? > A simple command list suffices as this is just about redirecting all > output at once. > > Feedback/OK? > > Index: install.sub > === > RCS file:

Re: install.sub: No need for subshell in feed_random()

2017-07-01 Thread Klemens Nanni
On Sat, Jul 01, 2017 at 09:35:09PM -0700, Philip Guenther wrote: On Sat, Jul 1, 2017 at 9:27 PM, Klemens Nanni wrote: A simple command list suffices as this is just about redirecting all output at once. Feedback/OK? ... + {dmesg; cat $CGI_INFO /*.conf; sysctl; route

Re: install.sub: No need for subshell in feed_random()

2017-07-01 Thread Philip Guenther
On Sat, Jul 1, 2017 at 9:27 PM, Klemens Nanni wrote: > A simple command list suffices as this is just about redirecting all > output at once. > > Feedback/OK? ... > + {dmesg; cat $CGI_INFO /*.conf; sysctl; route -n show; df; This code has not been tested (and does not

install.sub: No need for subshell in feed_random()

2017-07-01 Thread Klemens Nanni
A simple command list suffices as this is just about redirecting all output at once. Feedback/OK? Index: install.sub === RCS file: /cvs/src/distrib/miniroot/install.sub,v retrieving revision 1.1016 diff -u -p -r1.1016 install.sub