On Tue, Dec 29, 2015 at 07:59:06PM +, Nicholas Marriott wrote:
> yes please, ok nicm
>
also ok with me. The vi.c change would be fine with me since it fixes
another shadowing issue, but please don't commit the emacs.c change.
ok tb@
yes please, ok nicm
On Tue, Dec 29, 2015 at 12:15:25PM -0500, Ted Unangst wrote:
> I'm slowly trimming down some of the -Wshadow warnings in bin and one big
> offender is ksh. Namely, it has a local variable e that shadows a global e.
>
> -struct env *e;
> +struct env *genv;
>
> Normal
On Tue, 29 Dec 2015 12:15:25 -0500, "Ted Unangst" wrote:
> I'm slowly trimming down some of the -Wshadow warnings in bin and one big
> offender is ksh. Namely, it has a local variable e that shadows a global e.
>
> -struct env *e;
> +struct env *genv;
>
> Normally I rename the local, but
I'm slowly trimming down some of the -Wshadow warnings in bin and one big
offender is ksh. Namely, it has a local variable e that shadows a global e.
-struct env *e;
+struct env *genv;
Normally I rename the local, but in this case I think the global deserves a
better name. Note that this
