Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2018-02-18 Thread Alexander Hall
On February 18, 2018 6:37:52 PM GMT+01:00, Robert Peichaer wrote: >On Sun, Feb 18, 2018 at 12:36:43PM +0100, Klemens Nanni wrote: >> On Tue, Nov 21, 2017 at 08:30:25PM +0100, Klemens Nanni wrote: >> > On Sun, Nov 12, 2017 at 10:43:46PM +0100, Klemens Nanni wrote: >> > > On

Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2018-02-18 Thread Robert Peichaer
On Sun, Feb 18, 2018 at 12:36:43PM +0100, Klemens Nanni wrote: > On Tue, Nov 21, 2017 at 08:30:25PM +0100, Klemens Nanni wrote: > > On Sun, Nov 12, 2017 at 10:43:46PM +0100, Klemens Nanni wrote: > > > On Sun, Nov 12, 2017 at 09:04:22PM +, Robert Peichaer wrote: > > > > Hmm. I see. > > > > > >

Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2018-02-18 Thread Klemens Nanni
On Tue, Nov 21, 2017 at 08:30:25PM +0100, Klemens Nanni wrote: > On Sun, Nov 12, 2017 at 10:43:46PM +0100, Klemens Nanni wrote: > > On Sun, Nov 12, 2017 at 09:04:22PM +, Robert Peichaer wrote: > > > Hmm. I see. > > > > > > The {add,del,no,pre}_path functions are in ksh.kshrc since when it was

Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2017-11-21 Thread Klemens Nanni
On Sun, Nov 12, 2017 at 10:43:46PM +0100, Klemens Nanni wrote: > On Sun, Nov 12, 2017 at 09:04:22PM +, Robert Peichaer wrote: > > Hmm. I see. > > > > The {add,del,no,pre}_path functions are in ksh.kshrc since when it was > > imported 21 years ago. If they would be used in ksh.kshrc or

Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2017-11-12 Thread Klemens Nanni
On Sun, Nov 12, 2017 at 09:04:22PM +, Robert Peichaer wrote: > Hmm. I see. > > The {add,del,no,pre}_path functions are in ksh.kshrc since when it was > imported 21 years ago. If they would be used in ksh.kshrc or anywhere > else, I'd say it might be worth "fixing" these functions. But they

Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2017-11-12 Thread Robert Peichaer
On Sun, Nov 12, 2017 at 12:22:27AM +0100, Klemens Nanni wrote: > On Sat, Nov 11, 2017 at 08:03:36PM +, Robert Peichaer wrote: > > On Sat, Nov 11, 2017 at 08:11:25PM +0100, Klemens Nanni wrote: > > > pre_path()ing directories with spaces is broken due to bad quoting. > > > > > > This diff

Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2017-11-11 Thread Klemens Nanni
On Sat, Nov 11, 2017 at 08:03:36PM +, Robert Peichaer wrote: > On Sat, Nov 11, 2017 at 08:11:25PM +0100, Klemens Nanni wrote: > > pre_path()ing directories with spaces is broken due to bad quoting. > > > > This diff takes care of that by properly passing double quotes through > > eval and

Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2017-11-11 Thread Robert Peichaer
On Sat, Nov 11, 2017 at 08:11:25PM +0100, Klemens Nanni wrote: > pre_path()ing directories with spaces is broken due to bad quoting. > > This diff takes care of that by properly passing double quotes through > eval and quoting the arguments for no_path() individually. > > Feedback? What is

ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2017-11-11 Thread Klemens Nanni
pre_path()ing directories with spaces is broken due to bad quoting. This diff takes care of that by properly passing double quotes through eval and quoting the arguments for no_path() individually. Feedback? diff --git a/etc/ksh.kshrc b/etc/ksh.kshrc index 5b5bd040f79..66736da5e11 100644 ---