On Mon, May 02, 2022 at 08:39:07PM -0500, Scott Cheloha wrote:
> On Sat, Apr 30, 2022 at 01:27:44AM +0200, Alexander Bluhm wrote:
> > otherwise diff looks good to me
>
> Still look good?
OK bluhm@
> Index: kstat.c
> ===
> RCS file:
On Mon, 02 May 2022 20:39:07 -0500, Scott Cheloha wrote:
> Whenever I block signals, deraadt@ rises up out of the floorboards and
> says "I hate masking signals, don't do that."
>
> ... but if millert@ is still fine with the attached patch, which does
> sigprocmask(2), I'll go ahead with it.
>
> >
On Sat, Apr 30, 2022 at 01:27:44AM +0200, Alexander Bluhm wrote:
> On Thu, Apr 28, 2022 at 08:54:02PM -0500, Scott Cheloha wrote:
> > On Thu, Sep 17, 2020 at 06:29:48PM -0500, Scott Cheloha wrote:
> > > [...]
> > >
> > > Using nanosleep(2) to print the stats periodically causes the period
> > > to
On Thu, Apr 28, 2022 at 08:54:02PM -0500, Scott Cheloha wrote:
> On Thu, Sep 17, 2020 at 06:29:48PM -0500, Scott Cheloha wrote:
> > [...]
> >
> > Using nanosleep(2) to print the stats periodically causes the period
> > to drift. If you use setitimer(2) it won't drift.
> >
> > ok?
>
> 19 month b
On Thu, 28 Apr 2022 20:54:02 -0500, Scott Cheloha wrote:
> Once again, using nanosleep(2) here to print the stats periodically is
> flawed. The period will drift. Using setitimer(2)/sigsuspend(2) is
> better.
Yes, I agree that an interval timer is a better fit.
> While here:
>
> - We don't nee
On Thu, Sep 17, 2020 at 06:29:48PM -0500, Scott Cheloha wrote:
> [...]
>
> Using nanosleep(2) to print the stats periodically causes the period
> to drift. If you use setitimer(2) it won't drift.
>
> ok?
19 month bump and rebase.
I have updated the patch according to input from kn@.
Once agai
Hi,
Using nanosleep(2) to print the stats periodically causes the period
to drift. If you use setitimer(2) it won't drift.
ok?
Index: kstat.c
===
RCS file: /cvs/src/usr.bin/kstat/kstat.c,v
retrieving revision 1.6
diff -u -p -r1.6 k
