Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Patrick Wildt
On Tue, Nov 30, 2021 at 03:24:17PM -0700, Theo de Raadt wrote: > Todd C. Miller wrote: > > > On Tue, 30 Nov 2021 23:18:23 +0100, Mark Kettenis wrote: > > > > > Maybe add a comment here that libfido2 depends on libz? > > > > > > > +SUBDIR+=libfido2 > > > > Yes, please. With a comment this is

Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Theo de Raadt
Todd C. Miller wrote: > On Tue, 30 Nov 2021 23:18:23 +0100, Mark Kettenis wrote: > > > Maybe add a comment here that libfido2 depends on libz? > > > > > +SUBDIR+=libfido2 > > Yes, please. With a comment this is OK millert@ Or just mark these as "phase 2", without saying why.

Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Todd C . Miller
On Tue, 30 Nov 2021 23:18:23 +0100, Mark Kettenis wrote: > Maybe add a comment here that libfido2 depends on libz? > > > +SUBDIR+=libfido2 Yes, please. With a comment this is OK millert@ - todd

Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Mark Kettenis
> Date: Tue, 30 Nov 2021 23:04:49 +0100 > From: Patrick Wildt > > On Thu, Nov 11, 2021 at 08:27:21PM +0900, SASANO Takayoshi wrote: > > Hi, > > > > Recently I tried to crossbuild for arm64 on amd64. > > I found "TARGET=arm64 make cross-tools" stops when building libfido2. > > > > libfido2

Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Patrick Wildt
On Thu, Nov 11, 2021 at 08:27:21PM +0900, SASANO Takayoshi wrote: > Hi, > > Recently I tried to crossbuild for arm64 on amd64. > I found "TARGET=arm64 make cross-tools" stops when building libfido2. > > libfido2 requires libz but this is not built yet at that time. > lib/Makefile needs to tweak

lib/Makefile: libfido2 requires libz

2021-11-11 Thread SASANO Takayoshi
Hi, Recently I tried to crossbuild for arm64 on amd64. I found "TARGET=arm64 make cross-tools" stops when building libfido2. libfido2 requires libz but this is not built yet at that time. lib/Makefile needs to tweak like this. openbsd-current-vm# diff -uNpr Makefile~ Makefile --- Makefile~