Re: libc: locale/rune.c input validation

2015-12-04 Thread Tobias Stoeckmann
Hi Ingo, On Fri, Dec 04, 2015 at 12:27:39PM +0100, Ingo Schwarze wrote: > uint32_t should be preferred because that's the POSIX type, while > u_int32_t is not standardized. If you are working on the file > anyway, i'd recommend to unify all uses to uint32_t. done. > __LP64__ that is overly

Re: libc: locale/rune.c input validation

2015-12-03 Thread Tobias Stoeckmann
Thanks Ingo for your extensive review! It contains lots of valuable input for me. I have applied all your recommendations, they make a lot of sense. > I would suggest to use uint32_t. Just while applying this, I noticed that the file has a mix of the types u_int32_t and uint32_t. I took

libc: locale/rune.c input validation

2015-12-02 Thread Tobias Stoeckmann
Hi, this patch adds a lot of input validation to libc/locale/rune.c. The kind of validations are borrowed from my nls changes some weeks ago. I've contacted stsp@ about this. I think it's ready to get more review from tech@. Let me know what you think! Tobias Index: rune.c