Re: libssl/src/apps don't cast {m,re}alloc

2014-04-24 Thread Thomas Pfaff
> This doesn't fix the problems, only removes markers alerting us > to audit it. > > Memory management in these files is still missing integer overflow > checks, NULL return checks, and is full of crazy abominations [...] Yes, I saw that but I thought I'd take care of one thing first then send pa

Re: libssl/src/apps don't cast {m,re}alloc

2014-04-23 Thread Jean-Philippe Ouellet
This doesn't fix the problems, only removes markers alerting us to audit it. Memory management in these files is still missing integer overflow checks, NULL return checks, and is full of crazy abominations like: X509_NAME * parse_name(char *subject, long chtype, int multirdn) { size_t buf

libssl/src/apps don't cast {m,re}alloc

2014-04-23 Thread Thomas Pfaff
Don't cast {m,re}alloc. No point and it's inconsistent already. Index: apps.c === RCS file: /cvs/src/lib/libssl/src/apps/apps.c,v retrieving revision 1.42 diff -u -p -r1.42 apps.c --- apps.c 22 Apr 2014 14:54:13 - 1.42